Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status-checks): switching to a polling job for status checks #686

Merged
merged 2 commits into from
Aug 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/ecs-codedeploy/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ runs:
with:
token: ${{ github.token }}
environment-url: https://${{ fromJSON(inputs.terraform-output).ecs-application-url.value }}
environment: ${{ inputs.name }}${{ github.ref == 'refs/heads/dev' && '-dev' }}
environment: ${{ inputs.name }}${{ github.ref == 'refs/heads/dev' && '-dev' || '' }}
transient-environment: ${{ github.ref == 'refs/heads/main' && 'false' || 'true' }}
production-environment: ${{ github.ref == 'refs/heads/main' && 'true' || 'false' }}
initial-status: pending
Expand Down
52 changes: 11 additions & 41 deletions .github/workflows/status-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,49 +5,19 @@
# We also use this because re-usable workflows can not be targeted for Github Required Status Checks as of 8/15/2024
name: Status Checks
on:
workflow_run:
workflows:
- Pull Request
- User API
- List API
- Account Delete Monitor
- Annotations API
- Braze
- Client API
- Feature Flags
- FxA Webhook Proxy
- Image API
- Instant Sync Events
- Parser GraphQL Wrapper
- Pocket Event Bridge
- Push Server
- Sendgrid Data
- Shareable Lists API
- Shared Snowplow Consumer
- Shares API
- Transactional Emails
- V3 Proxy API
- User List Search
types: [ completed ]
pull_request:

jobs:
status-check:
runs-on: ubuntu-latest

if: always()
steps:
- uses: actions/checkout@v2
- uses: ahmadnassri/action-workflow-run-wait@v1

# Note: If the workflow_run trigger does not work out, this can be used instead with a pull_request event to trigger a long polling job.
# status-check:
# runs-on: ubuntu-latest
# steps:
# - name: Wait for workflows
# id: wait
# uses: smartcontractkit/chainlink-github-actions/utils/wait-for-workflows@main
# with:
# max-timeout: "900"
# polling-interval: "15"
# exclude-workflow-names: ""
# exclude-workflow-ids: ""
# github-token: ${{ secrets.GITHUB_TOKEN }}
- name: Wait for workflows
id: wait
uses: smartcontractkit/chainlink-github-actions/utils/wait-for-workflows@main
with:
max-timeout: "900"
polling-interval: "15"
exclude-workflow-names: ""
exclude-workflow-ids: ""
github-token: ${{ secrets.GITHUB_TOKEN }}
Loading