fix: cast configcat.log.level into integer #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be a problem where this could be set via environment variables
```.env
CONFIGCAT_LOG_LEVEL=50
```
which would correspond to
```php
ConfigCat\Log\LogLevel::ERROR;
```
but would be interpreted as strings `"50"` instead of the value of the constant, which is an integer.
```php
<?php
namespace ConfigCat\Log;
class LogLevel
{
// ...
const ERROR = 50;
// ...
}
```
cfpinto
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a problem where this could be set via environment variables
which would correspond to
but would be interpreted as strings
"50"instead of the value of the constant, which is an integer.