Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 10 + PHP 8.2 Support #20

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Laravel 10 + PHP 8.2 Support #20

merged 8 commits into from
Sep 1, 2023

Conversation

clnt
Copy link
Contributor

@clnt clnt commented Aug 31, 2023 •
edited
Loading

Hi @clemblanco,

I am looking to upgrade an application which is using this package to Laravel 10, in summary I have made the following changes:

  • Dropped PHP 8.0 support, now PHP ^8.1.
  • Laravel 9 & 10 Support (feel free to drop the L9 support if you wish).
  • GitHub Actions workflow updated for Laravel 10 + PHP 8.1, updated action versions to remove deprecation warnings.
  • phpunit.xml file migrated to newer configuration and update path to tests

This should probably go into a version 3.0.0 release.

Cheers!

@clnt clnt mentioned this pull request Aug 31, 2023
Closed
clemblanco
clemblanco approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@clemblanco clemblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@clemblanco clemblanco merged commit 4db5fe6 into Pod-Point:2.x Sep 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemblanco clemblanco clemblanco approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clnt @clemblanco