Skip to content

Commit

Permalink
chore: remove or modify miscellaneous comments
Browse files Browse the repository at this point in the history
  • Loading branch information
joshuagraber committed Dec 17, 2023
1 parent 0d03976 commit 10a8593
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
4 changes: 2 additions & 2 deletions release.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ module.exports = {
'@semantic-release/github',


/* TODO: Use either of the below strategies.
/* TODO: Use either of the below strategies to raise PR against `main` or commit directly to `main`
*** */
// 6. Update version with new release PR raised against main (in lieu of direct commit for now)
// If we're going to use this, it will require a shim. See errors in console.
Expand All @@ -77,7 +77,7 @@ module.exports = {
// ]


// TODO: Fix token so that /git will work
// TODO: Fix token
// // 6. Update version with new release commit (must be called after /changelog and /npm)
// [
// '@semantic-release/git',
Expand Down
4 changes: 2 additions & 2 deletions src/components/Nav/nav.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const base = {
config: {
warnHandler(msg, instance, trace) {
if (
// TODO: investigate these cases (happening anywhere nav is rendered)
// TODO: investigate these cases
msg.includes('Invalid prop: type check failed for prop') ||
msg.includes('missing template')
) {
Expand Down Expand Up @@ -62,7 +62,7 @@ describe('Nav component', () => {
});

test('Renders mobile nav', () => {
// TODO: how to check?
// TODO: check this
});

test('Renders empty nav when links are undefined', () => {
Expand Down
5 changes: 1 addition & 4 deletions tools/testing/serializer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
/* c8 ignore next 30 */
import { print as _print } from 'jest-serializer-vue-tjw';

// TODO:
// 1. Write tests
// 2. Fix typescript -- any type is not safe
// TODO: 1. Write tests, 2. Fix typescript -- any type is not safe

const helpers = {
isHtmlString: function (received: any) {
Expand All @@ -31,4 +29,3 @@ export default {
print,
test,
};
// TODO: Devise a test for this, so that we don't need to add c8 declaration ignoring it (code is more or less boilerplate from c8 - https://github.com/tjw-lint/jest-serializer-vue-tjw/#using-with-vitest)

0 comments on commit 10a8593

Please sign in to comment.