hotfix: quick search form not receiving values in handler (#26)

* hotfix: QuickSearchForm not handling values

* test: update misc tests and snapshots

* chore(cleanup): remove logs

* chore(version): bump lib version

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pdap-design-system",
-	"version": "2.0.3",
+	"version": "2.0.4",
 	"description": "Global styles for PDAP apps",
 	"author": "Police Data Accessibility Project, Inc.",
 	"license": "ISC",

src/components/Footer/__snapshots__/footer.spec.ts.snap

@@ -9,7 +9,7 @@ exports[`Footer component > Renders a footer 1`] = `
         <!--v-if-->
       </li>
       <li class="pdap-footer-link-container">
-        <a class="pdap-footer-social-link" href="ttps://discord.gg/wMqex8nKZJ" referrerpolicy="no-referrer" target="_blank">Discord</a>
+        <a class="pdap-footer-social-link" href="https://discord.gg/wMqex8nKZJ" referrerpolicy="no-referrer" target="_blank">Discord</a>
         <!--v-if-->
       </li>
       <li class="pdap-footer-link-container">

src/components/Form/PdapForm.vue

@@ -124,7 +124,7 @@ async function submit(event: Event) {
 	const isValidSubmission = await v$.value.$validate();
 	if (isValidSubmission) {
 		// Emit submit event (spread to new object to create new object, this allows us to reset `values` without messing with the data returned)
-		emit('submit', { ...values });
+		emit('submit', { ...values.value });
 		// Reset vuelidate and form
 		v$.value.$reset();
 		const form = <HTMLFormElement>event.target;

src/components/QuickSearchForm/QuickSearchForm.vue

@@ -52,13 +52,8 @@ const formSchema = [
 	},
 ];
 
-function handleSubmit({
-	location,
-	searchTerm,
-}: {
-	location: string;
-	searchTerm: string;
-}) {
+function handleSubmit(values: { location: string; searchTerm: string }) {
+	let { location, searchTerm } = values;
 	location = location && location.length > 0 ? location : 'all';
 	searchTerm = searchTerm && searchTerm.length > 0 ? searchTerm : 'all';
 	// If search route exists, route to it

src/components/QuickSearchForm/__snapshots__/quick-search-form.spec.ts.snap

@@ -2,7 +2,6 @@
 
 exports[`QuickSearchForm component > Renders a QuickSearchForm 1`] = `
 <div class="pdap-flex-container pdap-flex-container-center pdap-quick-search-form">
-  <p class="quick-search-description"> We maintain a catalog of public records about police, court, and jail systems across the United States. </p>
   <form class="pdap-form small">
     <!--v-if-->
     <div class="pdap-grid-container pdap-input">

src/components/QuickSearchForm/quick-search-form.spec.ts

@@ -61,12 +61,12 @@ describe('QuickSearchForm component', () => {
 		expect((locationInput.element as HTMLInputElement).value).toBe('bar');
 
 		// Submit
-		await wrapper.find('form').trigger('submit');
+		await wrapper.find('form').trigger('submit.prevent');
 		await nextTick();
 
 		// Assert submit event
 		expect(wrapper.emitted()).toHaveProperty('submit');
-
+		expect(wrapper.emitted('submit')?.length).toBe(1);
 		// TODO: how to test router push called via form submit event. Not working anywhere.
 		// expect(push).toHaveBeenCalledWith('/search/foo/bar');
 	});