-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): checkbox input updates #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look and have some feedback:
- I think the cursor should change to interactive click
- Possibly the click target should be larger
@vikramrojo Can you say more about this? The checkbox and its label are clickable. What part are you wanting to be larger? |
@joshuagraber maybe it was just the missing cursor, but I couldn't make out what the target area was. It looks good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design wise it looks good.
🎉 This PR is included in version 2.7.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #62
To test
npm run dev