Skip to content

visual tweaks#211

Merged
josh-chamberlain merged 13 commits intodevfrom
visual-tweaks
Jan 30, 2025
Merged

visual tweaks#211
josh-chamberlain merged 13 commits intodevfrom
visual-tweaks

Conversation

@josh-chamberlain
Copy link
Copy Markdown
Contributor

@josh-chamberlain josh-chamberlain commented Jan 26, 2025

Contains

  • visually tunes search results (spacing, colors)
  • visually tunes data source detail
  • formats available removed from rows
  • moves some single-use classes to in-context tailwind styles
  • removes padding overrides for main (set from pdap-design-system)

Acceptance criteria

  • run npm i && npm run dev
  • ensure things look good

Copy link
Copy Markdown
Collaborator

@joshuagraber joshuagraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. I'm also not seeing the issue with the footer on the search results page, checked in Firefox and Chrome. But I'll keep an eye out for it in future testing.

EDIT: do we want to approve and merge the design-system PR first so we can bump to the next beta release in this PR?

Screen.Recording.2025-01-28.at.10.02.38.AM.mov

@josh-chamberlain josh-chamberlain merged commit f9f957a into dev Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants