-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README for getting test environment up #1737
Conversation
README.md
Outdated
4. Start a server on localhost to see your changes | ||
### 4. Start a server on localhost to see your changes | ||
|
||
In api.py, comment out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can actually remove the CORS instructions, since the CORS errors were occurring due to Apple bluetooth jacking port 5000
README.md
Outdated
|
||
Return to policyengine-api folder and relevant python environment and run: | ||
``` | ||
POLICYENGINE_DB_PASSWORD="" python policyengine_api/worker.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will sound super nitpicky, but we've had issues in the past, so you might want to write something like "PASSWORD_HERE" inside the quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up-to-date, @rachel-lawrie, this was sorely needed. I left a couple minor suggestions, but after that, it'd be great to have this merged!
README.md
Outdated
|
||
### 6. Testing calculations | ||
|
||
To test anything that utilizes Redis or the API's service workers (e.g. anything that requires calculations), you'll also need to complete the following steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To test anything that utilizes Redis or the API's service workers (e.g. anything that requires calculations), you'll also need to complete the following steps: | |
To test anything that utilizes Redis or the API's service workers (e.g. anything that requires society-wide calculations with the policy calculator), you'll also need to complete the following steps: |
Technically, this doesn't affect household calculations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this comprehensive workup, @rachel-lawrie! This'll be great to have for onboarding new contributors.
Fixes #1759