fix: ensure enum columns decode to strings for non-URL dataset paths#1504
Merged
nwoodruff-co merged 4 commits intomainfrom Feb 23, 2026
Merged
fix: ensure enum columns decode to strings for non-URL dataset paths#1504nwoodruff-co merged 4 commits intomainfrom
nwoodruff-co merged 4 commits intomainfrom
Conversation
_pre_encode_enum_columns was only called in build_from_url, so _enum_columns was never populated when a UKSingleYearDataset or UKMultiYearDataset was passed directly. The .person/.benunit/.household properties then returned raw int16 values instead of string enum labels. Now calls _pre_encode_enum_columns in build_from_single_year_dataset and guards build_from_multi_year_dataset to encode if not already done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_pre_encode_enum_columnswas only called inbuild_from_url, so_enum_columnswas never populated when aUKSingleYearDatasetorUKMultiYearDatasetwas passed directly toMicrosimulation().person/.benunit/.householdproperty getters returned rawint16values instead of string enum labels (e.g.0instead of'FT_EMPLOYED')sim.dataset.data.personshowing integers in policyengine.py contextChanges
_pre_encode_enum_columnsinbuild_from_single_year_datasetafterextend_single_year_datasetbuild_from_multi_year_datasetto call_pre_encode_enum_columnsif_enum_columnsis not already populated (avoids redundant re-encoding from the URL cache path)Test plan
sim.dataset[year].person['current_education']returns string labels not integers whenMicrosimulationis initialised with aUKSingleYearDataset