fix to: Random Colored Artifacts Showing Up #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potential fix to the rectangles appearing in 4.2
nuke-web3
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Looks like a fix! I removed the commented out html code here, as we do not want this pattern replicated: if we are to use the slides in the book context, and any other, as pure markdown as possible will help avoid any of these kind of issues. Any html we use should be "universal" so it's not dependent on context to work 🤞
@kianenigma I hope you might add some extra speaker notes here for each slide, to describe what is being show stepwise for people without context, and verify this flows as you expected.
@Asamartino where are the source files you created the svgs here with? Perhaps google draw? Or did you modify the svg source itself?
|
I modify the .svg source itself using inkscape :) |
Asamartino
changed the title
Asamartino
changed the title
Asamartino
changed the title
Asamartino
changed the title
kianenigma
approved these changes
Nov 11, 2023
deleted images to pass the ci-checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential solution to issue #8