-
Notifications
You must be signed in to change notification settings - Fork 150
add typecheck.yml #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add typecheck.yml #280
Conversation
Added CI typechecking to prevent type regressions from slipping into PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| with: | ||
| node-version: 18 | ||
| - run: npm ci | ||
| - run: npm run typecheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18 | ||
| - run: npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflow uses npm but project requires pnpm
High Severity
The workflow uses npm ci but this project uses pnpm as its package manager (specified in package.json with "packageManager": "pnpm@9.15.4"). The project only has a pnpm-lock.yaml, not a package-lock.json, so npm ci will fail. The existing release.yaml workflow shows the correct approach: enable corepack and use pnpm install --frozen-lockfile.
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js version below project's minimum requirement
Medium Severity
The workflow uses node-version: 18, but package.json specifies "engines": { "node": ">=20.10" }. The existing release.yaml workflow correctly uses node-version 24. Running typechecks with an unsupported Node.js version may produce incorrect results or fail.
Added CI typechecking to prevent type regressions from slipping into PRs.
Note
Medium Risk
CI-only change, but the new workflow may fail and block merges because it runs
npm ci/npm run typecheckon Node 18 despite the repo usingpnpmand requiring Node >=20.10.Overview
Adds a new GitHub Actions workflow (
.github/workflows/typecheck.yml) that runs on PRs and pushes tomainto install dependencies and executenpm run typecheck.Written by Cursor Bugbot for commit e7d67c6. This will update automatically on new commits. Configure here.