Skip to content

Conversation

@hiimpoop
Copy link

@hiimpoop hiimpoop commented Jan 29, 2026

Added CI typechecking to prevent type regressions from slipping into PRs.


Note

Medium Risk
CI-only change, but the new workflow may fail and block merges because it runs npm ci/npm run typecheck on Node 18 despite the repo using pnpm and requiring Node >=20.10.

Overview
Adds a new GitHub Actions workflow (.github/workflows/typecheck.yml) that runs on PRs and pushes to main to install dependencies and execute npm run typecheck.

Written by Cursor Bugbot for commit e7d67c6. This will update automatically on new commits. Configure here.

Added CI typechecking to prevent type regressions from slipping into PRs.
@hiimpoop hiimpoop requested a review from a team as a code owner January 29, 2026 18:35
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

with:
node-version: 18
- run: npm ci
- run: npm run typecheck
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow references non-existent typecheck script

High Severity

The workflow runs npm run typecheck, but no typecheck script exists in package.json. The scripts section only defines build, lint, deploy, and test. This CI job will always fail.

Fix in Cursor Fix in Web

- uses: actions/setup-node@v4
with:
node-version: 18
- run: npm ci
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow uses npm but project requires pnpm

High Severity

The workflow uses npm ci but this project uses pnpm as its package manager (specified in package.json with "packageManager": "pnpm@9.15.4"). The project only has a pnpm-lock.yaml, not a package-lock.json, so npm ci will fail. The existing release.yaml workflow shows the correct approach: enable corepack and use pnpm install --frozen-lockfile.

Fix in Cursor Fix in Web

- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js version below project's minimum requirement

Medium Severity

The workflow uses node-version: 18, but package.json specifies "engines": { "node": ">=20.10" }. The existing release.yaml workflow correctly uses node-version 24. Running typechecks with an unsupported Node.js version may produce incorrect results or fail.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant