Skip to content

chore: add linting workflow #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheMagamed78 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add linting workflow #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Lint

on: [push, pull_request]

jobs:
flake8:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.9'
- name: Install flake8
run: pip install flake8
- name: Run flake8
run: flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
Copy link

@cursor cursor bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python linter added to TypeScript-only project

Medium Severity

This workflow adds flake8 (a Python linter) to a TypeScript project that contains no Python files. The linting step will always pass without checking any actual code because flake8 only processes .py files. The PR's stated goal of "ensuring code quality and preventing syntax errors" cannot be achieved since the codebase is TypeScript. The project already has ESLint configured for TypeScript linting in .eslintrc.cjs and the release workflow runs pnpm lint.

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python linting workflow added to TypeScript-only repository

Low Severity

This workflow adds Python flake8 linting to a TypeScript/JavaScript repository that contains no Python files. The codebase is an npm package (@polymarket/clob-client) with TypeScript source files, and the existing workflow.yaml already runs pnpm lint for TypeScript via ESLint. This flake8 workflow will run on every push and pull request, consuming CI resources to lint non-existent Python code.

Fix in Cursor Fix in Web