Gas Snapshots #26
Merged
Gas Snapshots #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GasSnapshots.t.sol with 16 tests covering: - Complementary (1/5/10/20 makers) - Mint (1/5/10/20 makers) - Merge (1/5/10/20 makers) - Combo complementary+mint (10/20 makers) - Combo complementary+merge (10/20 makers) - Update forge-std to v1.11.0 for vm.startSnapshotGas support - Remove unused dev scripts with broken imports
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive gas snapshot testing for the matchOrders function and updates the forge-std dependency to the official Foundry repository.
Changes:
- Added gas snapshot tests covering complementary, mint, merge, and combination scenarios with varying numbers of maker orders (1, 5, 10, 20)
- Updated forge-std submodule to official Foundry repository and newer commit
- Removed unused script files (poolBytecodeHash.s.sol and ZeroTx.s.sol)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/exchange/test/GasSnapshots.t.sol | New test file implementing gas snapshot benchmarks for matchOrders scenarios |
| snapshots/GasSnapshots_Test.json | Gas measurement results from running the snapshot tests |
| lib/forge-std | Updated submodule pointer to newer commit |
| .gitmodules | Changed forge-std source from brockelmore fork to official foundry-rs repository |
| src/dev/script/poolBytecodeHash.s.sol | Removed unused script file |
| src/dev/script/ZeroTx.s.sol | Removed unused script file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JonathanAmenechi
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Adds a comprehensive gas snapshot suite for
exchange.matchOrdersand updates testing tooling.GasSnapshots_Testinsrc/exchange/test/GasSnapshots.t.solcovering complementary, mint, merge, and combo scenarios with varying maker counts; usesvm.startSnapshotGas/vm.stopSnapshotGassnapshots/GasSnapshots_Test.jsonlib/forge-stdsubmodule tofoundry-rs/forge-stdand locks to tagv1.14.0; cleans upfoundry.locksrc/dev/script/ZeroTx.s.solandsrc/dev/script/poolBytecodeHash.s.solWritten by Cursor Bugbot for commit 21d7471. This will update automatically on new commits. Configure here.