Update deploy_adapter.sh #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # Output the captured error message if available | ||
| echo "${DEPLOY_OUTPUT}" >&2 | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Bug: Error check unreachable due to set -e
The error check on line 36 is unreachable because set -e on line 6 causes the script to exit immediately if the forge script command fails. When the command in the command substitution returns a non-zero exit status, the script terminates before reaching the if [ $? -ne 0 ] check, making the error handling code ineffective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Harden deploy script with strict mode, improved logging, robust forge execution, and reliable adapter address extraction via jq.
set -euo pipefailand structured logging of env-based deploy args.deployAdapter(address,address,address,address)signature with quoted args.jq .returns.adapter.valueand print success summary.Written by Cursor Bugbot for commit 965e94f. This will update automatically on new commits. Configure here.