Remove batch container store ops flag

PiperOrigin-RevId: 363735592
PolymerLabs · Mar 18, 2021 · a6ab44f · a6ab44f
1 parent 4237862
commit a6ab44f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 36 deletions.
diff --git a/java/arcs/core/storage/ReferenceModeStore.kt b/java/arcs/core/storage/ReferenceModeStore.kt
@@ -280,33 +280,17 @@ class ReferenceModeStore private constructor(
             is BridgingOperation.ClearSet -> clearAllEntitiesInBackingStore()
           }
 
-          if (BuildFlags.BATCH_CONTAINER_STORE_OPS) {
-            containerOps.add(op.containerOp)
-            upstreamOps.add(op.refModeOp)
-          } else {
-            containerStore.onProxyMessage(
-              ProxyMessage.Operations(listOf(op.containerOp), containerStoreId)
-            )
-            sendQueue.enqueue {
-              val upstream = listOf(op.refModeOp)
-              callbacks.allCallbacksExcept(proxyMessage.id).forEach { callback ->
-                callback(
-                  ProxyMessage.Operations(upstream, id = proxyMessage.id)
-                )
-              }
-            }
-          }
+          containerOps.add(op.containerOp)
+          upstreamOps.add(op.refModeOp)
         }
-        if (BuildFlags.BATCH_CONTAINER_STORE_OPS) {
-          containerStore.onProxyMessage(
-            ProxyMessage.Operations(containerOps, containerStoreId)
-          )
-          sendQueue.enqueue {
-            callbacks.allCallbacksExcept(proxyMessage.id).forEach { callback ->
-              callback(
-                ProxyMessage.Operations(upstreamOps, id = proxyMessage.id)
-              )
-            }
+        containerStore.onProxyMessage(
+          ProxyMessage.Operations(containerOps, containerStoreId)
+        )
+        sendQueue.enqueue {
+          callbacks.allCallbacksExcept(proxyMessage.id).forEach { callback ->
+            callback(
+              ProxyMessage.Operations(upstreamOps, id = proxyMessage.id)
+            )
           }
         }
       }

diff --git a/javatests/arcs/core/storage/ReferenceModeStoreTest.kt b/javatests/arcs/core/storage/ReferenceModeStoreTest.kt
@@ -44,7 +44,6 @@ class ReferenceModeStoreTest(
     @get:Parameterized.Parameters(name = "{0}")
     val PARAMETERS = ParameterizedBuildFlags.of(
       "STORAGE_STRING_REDUCTION",
-      "BATCH_CONTAINER_STORE_OPS",
       "REFERENCE_MODE_STORE_FIXES"
     )
   }

diff --git a/third_party/java/arcs/flags/flags.bzl b/third_party/java/arcs/flags/flags.bzl
@@ -91,15 +91,6 @@ ARCS_BUILD_FLAGS = [
             "DatabaseOp",
         ],
     ),
-    arcs_build_flag(
-        name = "batch_container_store_ops",
-        bug_id = "b/182508100",
-        desc = "Batch container store ops in ref mode store for improved performance.",
-        status = "NOT_READY",
-        stopwords = [
-            "batch.?container.?store.?ops",
-        ],
-    ),
     arcs_build_flag(
         name = "reference_mode_store_fixes",
         desc = "Resolve several reference mode store bugs",