forked from PolymeshAssociation/polymesh-rest-api
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Endpoint to clear value for an Asset Metadata - Endpoint to remove a Local Asset Metadata Also updates the SDK dependency to `23.0.0-alpha.37`
introduce 'options' to transaction base dto. `signer`, `dryRun` and `webhookUrl` should be placed in this new field. Top level has been marked as deprecated, but is still supported for now
allow consumer to use an enum "processMode" in transaction options. This avoids unexpected behavior by preventing multiple booleans from being passed, e.g. `noSign` together with `dryRun` could result in ambiguity. Legacy top level params will be converted
adds process mode 'offline' to return unsigned transaction payloads. Adds /transactions/submit to submit the transaction with the signature
allow users to specify account nonce and transaction mortality Signed-off-by: Eric Richardson <eric@polymesh.network>
- Endpoint to clear value for an Asset Metadata - Endpoint to remove a Local Asset Metadata Also updates the SDK dependency to `23.0.0-alpha.37` Signed-off-by: Eric Richardson <eric@polymesh.network>
introduce 'options' to transaction base dto. `signer`, `dryRun` and `webhookUrl` should be placed in this new field. Top level has been marked as deprecated, but is still supported for now Signed-off-by: Eric Richardson <eric@polymesh.network>
allow consumer to use an enum "processMode" in transaction options. This avoids unexpected behavior by preventing multiple booleans from being passed, e.g. `noSign` together with `dryRun` could result in ambiguity. Legacy top level params will be converted Signed-off-by: Eric Richardson <eric@polymesh.network>
# [5.0.0-alpha.2](PolymeshAssociation/polymesh-rest-api@v5.0.0-alpha.1...v5.0.0-alpha.2) (2023-12-18) ### Features * 🎸 add `options` field for tx details, like signer ([e7a0de8](PolymeshAssociation@e7a0de8)) * 🎸 add `options` field for tx details, like signer ([3977339](PolymeshAssociation@3977339)) * 🎸 add nonce and mortality tx options ([c753309](PolymeshAssociation@c753309)) * 🎸 add offline process mode ([a921686](PolymeshAssociation@a921686)) * 🎸 Adds new Asset Metadata endpoints ([f278c6e](PolymeshAssociation@f278c6e)) * 🎸 Adds new Asset Metadata endpoints ([87bf11a](PolymeshAssociation@87bf11a)) * 🎸 introduce `processMode` option to replace many bools ([87cbd15](PolymeshAssociation@87cbd15)) * 🎸 introduce `processMode` option to replace many bools ([599e020](PolymeshAssociation@599e020))
introduce 'options' to transaction base dto. `signer`, `dryRun` and `webhookUrl` should be placed in this new field. Top level has been marked as deprecated, but is still supported for now
allow consumer to use an enum "processMode" in transaction options. This avoids unexpected behavior by preventing multiple booleans from being passed, e.g. `noSign` together with `dryRun` could result in ambiguity. Legacy top level params will be converted
- add starter service for transactions service to use - add signer service that attempts signing all messages - add submitter service to submit signed tx to chain - add listener to record all messages echanged in a data store
removes signing manager getter so callers have a cleaner abstraction. Also updates tests to use an auto mock for the signing service
subquery image needs to be set for the compose file to be valid
# [5.0.0-alpha.3](PolymeshAssociation/polymesh-rest-api@v5.0.0-alpha.2...v5.0.0-alpha.3) (2024-01-12) ### Features * 🎸 add `options` field for tx details, like signer ([45bb420](PolymeshAssociation@45bb420)) * 🎸 add basic amqp flow ([6b6510d](PolymeshAssociation@6b6510d)) * 🎸 introduce `processMode` option to replace many bools ([bb1f889](PolymeshAssociation@bb1f889))
configure artemis MQ so expected addresses and queues are explicitly setup. Also adds graceful shutdown + elminates redudant connections
# [5.0.0-alpha.4](PolymeshAssociation/polymesh-rest-api@v5.0.0-alpha.3...v5.0.0-alpha.4) (2024-01-15) ### Features * 🎸 config artemis MQ explictly ([365ff6c](PolymeshAssociation@365ff6c))
adds loggers and sanity checks to artemis service
# [5.0.0-alpha.5](PolymeshAssociation/polymesh-rest-api@v5.0.0-alpha.4...v5.0.0-alpha.5) (2024-01-15) ### Features * 🎸 log errors on amqp connection errors ([d001db8](PolymeshAssociation@d001db8))
also adds offline request model, and revert script to run migrations down
routes messages to DLQ with reject method. also consistently use all lower case for logs
# [5.0.0-alpha.6](PolymeshAssociation/polymesh-rest-api@v5.0.0-alpha.5...v5.0.0-alpha.6) (2024-01-16) ### Features * 🎸 add address and nonce to tx model ([aaf685b](PolymeshAssociation@aaf685b)) * 🎸 set autoaccept to false ([11705aa](PolymeshAssociation@11705aa))
adds checks for when artemis is not configured + add some helpful fields to user exposed models
feat: 🎸 Add `GET confidential-transactions/:id/created-at`
# [1.0.0-alpha.5](v1.0.0-alpha.4...v1.0.0-alpha.5) (2024-04-15) ### Features * 🎸 Add `GET confidential-transactions/:id/created-at` ([400676e](400676e)) * 🎸 build multiplatform docker images ([f5565c2](f5565c2))
✅ Closes: DA-1141
feat: 🎸 extend public rest api and remove duplicate code
…consistently style: 💄 use consistent order in auditor verify model
ci: 🎡 Add submodule checkout in github workflow
ci: 🎡 Add swagger json to release assets
# [1.0.0-alpha.6](v1.0.0-alpha.5...v1.0.0-alpha.6) (2024-04-29) ### Features * 🎸 extend public rest api and remove duplicate code ([18f0b44](18f0b44))
POST /confidential-transactions/:id/auditor-verify is now POST /confidential-transactions/:id/verify-amounts. The endpoint now verifies transaction amounts if the key is the receiver of the transaction. The response now includes `isReceiver` and `amountDecrypted` fields. If `amountDecrypted` is true then `amount` will be present BREAKING CHANGE: 🧨 POST /confidential-transactions/:id/auditor-verify is now POST /confidential-transactions/:id/verify-amounts. Request payload has renamed param from `auditorKey` to `publicKey` ✅ Closes: DA-1143
# [1.0.0-alpha.7](v1.0.0-alpha.6...v1.0.0-alpha.7) (2024-05-03) ### Features * 🎸 upgrade auditor verify to work when key is receiver ([91844c9](91844c9)) ### BREAKING CHANGES * 🧨 POST /confidential-transactions/:id/auditor-verify is now POST /confidential-transactions/:id/verify-amounts. Request payload has renamed param from `auditorKey` to `publicKey` ✅ Closes: DA-1143
Quality Gate passedIssues Measures |
return ConfidentialAssetBalanceModel from GET /:confidentialAccount/incoming-balances/:confidentialAssetId and :confidentialAccount/balances/:confidentialAssetId BREAKING CHANGE: 🧨 GET /:confidentialAccount/incoming-balances/:confidentialAssetId and GET :confidentialAccount/balances/:confidentialAssetId return an object instead of a plain string ✅ Closes: DA-1248
VictorVicente
approved these changes
Jul 17, 2024
fixes getInvolvedConfidentialTransactions and getConfidentialVenues throwing internal server errors
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Link
N/A
Changelog / Description
Release V1 of polymesh-private REST API
Checklist -