select right configuration at build time #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 101ea45. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
Deploying with
|
| Latest commit: |
101ea45
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db903ed5.polyratings.pages.dev |
| Branch Preview URL: | https://local-fix.polyratings.pages.dev |
AddisonTustin
added a commit
that referenced
this pull request
Sep 23, 2023
* Add anonymized identifiers to submitted reports (#87) * chore: update versions (#91) * chore: update versions * fix: restore previous click behavior * Locally Develop with CF Workers (#89) * locally develop with CF workers * fix env types * make rating analyzer have a new format to increase modularity * removed console log * readme updates * Toggle mocked datastore/integrations based on deployment state (#92) * Toggle mocked datastore/integrations based on deployment state * tiny changes --------- Co-authored-by: mfish33 <maxmfishernj@gmail.com> * still not working * fix broken package lock npm/cli#4828 --------- Co-authored-by: Chris Lawson <Chris2fourlaw@users.noreply.github.com> Co-authored-by: AddisonTustin <addison@atustin.dev> * Rolling ids (#95) * rolling ids * add long about comment * fix missing namespace * fix lint * Rating Anonymous Identifiers (#94) * rating anonymous identifiers * fix lint and properly parse perspective response * linting fix * make all professor key a shared constant * Use anonymousIdDao for rating id --------- Co-authored-by: Addison Tustin <addison@atustin.dev> * Stop preview deployments from trying to target localhost (#96) * Stop preview deployments from defaulting to localhost * change local to local-dev to avoid .env collisions * fix single quote * select right configuration at build time (#97) --------- Co-authored-by: AddisonTustin <addison@atustin.dev> Co-authored-by: Chris Lawson <Chris2fourlaw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.