Skip to content

Conversation

ricopinazo
Copy link
Collaborator

@ricopinazo ricopinazo commented Aug 28, 2025

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Are there any further changes required?

  • make sure we actually saving the templates on disk in a test
  • maybe embeddings should not be enabled by default, which simply ignores any vectors on disk
  • make sure we have the appropriate blocking_io calls, especially around read/write operations on arroy
  • there might be some corner case where some old embedding sample is read from the cache but the actual model changed
  • rename scores to distances in rust/python/graphql apis
  • forbid graph names starting with a dot
  • make sure to add a graphql function to vectorise graphs on demand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant