-
Notifications
You must be signed in to change notification settings - Fork 65
Add ui-tests submodule and newest UI #2305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
louisch
wants to merge
26
commits into
master
Choose a base branch
from
feature/ui-tests-submodule
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13ca9d0
to
5b7be7e
Compare
miratepuffin
requested changes
Oct 10, 2025
0acda4a
to
84a3a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds the new UI tests repository as a submodule, and use it to test the open source UI that is hosted inside raphtory-graphql
Why are the changes needed?
UI tests would be good to have for both raphtory and also the private UI repository, so making it a submodule of both allows the same tests to be run for both.
Does this PR introduce any user-facing change? If yes is this documented?
UI is updated to newest version of UI, and a new rust runtime-only option for serving UI from a user provided public directory was also added.
How was this patch tested?
UI tests tested locally and through github actions. The runtime serve public dir has not been tested yet.
Are there any further changes required?
Slightly unrelated, but more automation for updating the UI files when a new UI release is made is still needed.