Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DetectWeakXSSProtectionHeader.bambda #84

Merged

Conversation

ctflearner
Copy link
Contributor

This script checks if the HTTP response contains a weak or misconfigured "X-XSS-Protection" header.

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

This script checks if the HTTP response contains a weak or misconfigured "X-XSS-Protection" header.
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, and apologies for the delay over the holiday period.

Could you please review the feedback points below?

Filter/Proxy/HTTP/DetectWeakXSSProtectionHeader.bambda Outdated Show resolved Hide resolved
Filter/Proxy/HTTP/DetectWeakXSSProtectionHeader.bambda Outdated Show resolved Hide resolved
Filter/Proxy/HTTP/DetectWeakXSSProtectionHeader.bambda Outdated Show resolved Hide resolved
@ctflearner
Copy link
Contributor Author

Did i have to change the code in the main file or should i comment the corrected code in the comment ?? Just confirm so that i can change it

@Hannah-PortSwigger
Copy link
Contributor

Hi @ctflearner

You can change the code yourself, and then we can review your changes.

Please let us know if you have any issues.

Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing the feedback! This looks good.

Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your submission. LGTM 👍

@PortSwiggerWiener PortSwiggerWiener merged commit bdfc1f2 into PortSwigger:main Jan 9, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants