-
Notifications
You must be signed in to change notification settings - Fork 797
feat: add support for linked Security Profile API keys, additional tests #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for linked Security Profile API keys, additional tests #1398
Conversation
|
✅ Reviewed the changes: Review of PANW Prisma AIRS Guardrail enhancements for API key handling, profile parameters, and test coverage. |
narengogi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good minor change
| } | ||
| ] | ||
| }, | ||
| "timeout": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not need to add this parameter, the gateway uses the x-portkey-timeout header as the parameter for timeout and is provided in the parameters object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! now updated.
- Remove timeout parameter from manifest.json, update tests and intercept.ts to reflect
3a46e44 to
8851aee
Compare
|
✅ Reviewed the changes: This PR introduces support for linked Security Profile API keys and enhances test coverage. Key areas for improvement include type safety and test reliability. |
…rsation tracking - Extract x-portkey-trace-id from request headers and use as tr_id in AIRS API calls - Enables correlation between Portkey logs and Prism AIRS AI Session IDs - Add test to verify trace ID extraction works correctly
|
✅ Reviewed the changes: Review of trace ID generation and test coverage for PANW Prisma AIRS integration |
Description
This PR enhances the PANW Prisma AIRS guardrail plugin with additional error handling, comprehensive test coverage, and support for additional configuration parameters.
Key Changes:
profile_id,app_name, andtimeoutparameters in the manifestprofile_nameoptional to support profiles linked directly to API keys in Strata Cloud ManagerMotivation
app_name,profile_id) enable better observability in Prisma AIRSType of Change
How Has This Been Tested?
Screenshots (if applicable)
Checklist
Related Issues
N/A