Skip to content

chore: randomize more and name non-sharded backups noshard #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fuziontech merged 1 commit into from
Jun 8, 2024
Merged

chore: randomize more and name non-sharded backups noshard #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion housewatch/clickhouse/backups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def execute_backup(
nodes = get_node_per_shard(cluster)
responses = []
for shard, node in nodes:
params["shard"] = shard
params["shard"] = shard if is_sharded else "noshard"
if base_backup:
query_settings["base_backup"] = f"S3('{base_backup}/{shard}', '{aws_key}', '{aws_secret}')"
final_query = query % (params or {}) if substitute_params else query
Expand Down
1 change: 1 addition & 0 deletions housewatch/clickhouse/clusters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,5 @@ def get_node_per_shard(cluster):
break
if not preferred_replica_found:
nodes.append((shard, random.choice(n)))
random.shuffle(nodes)
return nodes