This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
kafka sink: expose more rdkafka settings #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/rdk-settings
branch
from
2914c70 to
8dbfe95
Compare
ellie
approved these changes
Nov 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to configure a few kafka parameters affecting performance and cost:
linger.ms, using a default of 20ms (higher than rdk's 5ms default), to reduce MSK pressurequeue.buffering.max.kbytes, doing to 400MiB down from rdk's 1GiB default, to avoid OOMingcompression.codec, leaving the default tononefor now, will run it withgzipon dev and make sure it does not break plugin-server, then change that defaultThere'll be more to come, but it's a good start.