-
Notifications
You must be signed in to change notification settings - Fork 61
feat: add manual start and stop recording #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
marandaneto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left 2 comments otherwise LGTM
|
Hi PostHog team, Thanks for adding this feature for Flutter. I've tried out this feature branch on an app and followed the instructions here. I have the This is my config: final posthogConfig = PostHogConfig(_config.posthogApiKey);
posthogConfig.host = _config.posthogHost;
posthogConfig.debug = kDebugMode;
posthogConfig.captureApplicationLifecycleEvents = true;
posthogConfig.sessionReplay = false;
posthogConfig.sessionReplayConfig.maskAllTexts = false;
posthogConfig.sessionReplayConfig.maskAllImages = false;
// Some time later...
Posthog().startSessionRecording(resumeCurrent: false)
// Also tried it with
Posthog().startSessionRecording(resumeCurrent: true)
Both The recording work normally when I set I also tried to manually remove the // posthog_widget.dart - PostHogWidgetState, L34
if (config == null || !config.sessionReplay) {
return;
}iOS 26.0 Simulator & a real Device, Flutter 3.35.7 |
|
Hey @ForTheYin thanx for testing this out! 🙏 I also noticed the same thing happen to me yesterday during a final test before releasing and held off the merge. This used to work fine before so it must be either some late changes made here or in the ingestion side of things. I'll try to sort this asap |
|
Actually let me correct myself, this used to work with the config enabled, so the happy path you describe here. I bumped into the same issue when config was disabled |
|
Okay turns out that PostHogWidget was disabled because of config, and we had no way of dynamically re-enabling it. @marandaneto pushed a fix for this in |
💡 Motivation and Context
Closes #124
Docs PR: PostHog/posthog.com#14487
💚 How did you test it?
Manual testing:
📝 Checklist