fix: dont require double click to show feedback surveys #1767
Conversation
lucasheriques
added
bump patch
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a new onSurveyDismissedOrSent callback function to the SurveyContext to fix an issue with widget-type surveys requiring double clicks to reappear after dismissal.
- Added
onSurveyDismissedOrSentcallback toSurveyContextinterface insrc/extensions/surveys/surveys-utils.tsxwith a default no-op implementation - Implemented the callback in
SurveyPopupcomponent insrc/extensions/surveys.tsxto properly handle survey state - Added callback invocation when surveys are dismissed or completed to reset widget state
- Fixed the issue where widget-type surveys required two clicks to show again after being dismissed
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +1.96 kB (+0.06%) Total Size: 3.32 MB
ℹ️ View Unchanged
|
yeah I wonder if |
I agree this is probably confusing, and there's a refactor somewhere we can do to make the logic be more sound but it's not on the scope of this PR specifically - where I'm mainly looking for adding a callback that will be triggered on both cases (dismissing or sending the survey) |
I think the confusion here is that there are one action and 2 callback options I'd rather do |
There was a problem hiding this comment.
left a last question here
i might be misunderstanding the behaviour of both callbacks, so feel free to explain and merge it if that's the case
|
@marandaneto @ioannisj i made the callbacks be more clear now please take another look before I merge 🙏 |
src/extensions/surveys.tsx
Outdated
| const { | ||
| isPreviewMode, | ||
| previewPageIndex, | ||
| onPopupSurveyDismissed: handleCloseSurveyPopup, |
There was a problem hiding this comment.
isnt handleCloseSurveyPopup renamed?
There was a problem hiding this comment.
thats what I get from trusting the automatic renaming; i'll fix all of those and merge
src/extensions/surveys.tsx
Outdated
| {isPopup && ( | ||
| <Cancel | ||
| onClick={() => { | ||
| handleCloseSurveyPopup() |
There was a problem hiding this comment.
src/extensions/surveys.tsx
Outdated
| onPopupSurveyDismissed: handleCloseSurveyPopup, | ||
| isPopup, | ||
| onPreviewSubmit, | ||
| onPopupSurveySent: onSurveyDismissedOrSent, |
There was a problem hiding this comment.
isnt onSurveyDismissedOrSent renamed?
| @@ -1071,6 +1073,81 @@ describe('useHideSurveyOnURLChange', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| describe('onSurveyDismissedOrSent callback', () => { | |||
There was a problem hiding this comment.
tests are using the old callback names
lucasheriques
deleted the
fix/dont-require-double-click-to-show-feedback-survey
branch
Changes
adds a new option on SurveyContext to do something after a survey is submitted.
also, right now, for widget-type surveys (tab style), we have to click on the button twice to show the survey again after dismissing it. this PR fixes that
Checklist