React Router docs #14258
Merged
React Router docs #14258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
edwinyjlim
approved these changes
Jan 5, 2026
Member
edwinyjlim
left a comment
edwinyjlim
left a comment
There was a problem hiding this comment.
huge!
For another time and place, but I'm starting to get a little queezy looking at the split between SDK vs Framework docs.
contents/docs/libraries/react-router/react-router-v7-framework-mode.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/react-router-v7-framework-mode.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/react-router-v7-framework-mode.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/react-router-v7-declarative-mode.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/react-router-v7-declarative-mode.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/react-router-v7-framework-mode.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/react-router-v7-framework-mode.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/react-router-v7-framework-mode.mdx
Outdated
Show resolved
Hide resolved
sarahxsanders
approved these changes
Jan 5, 2026
Contributor
sarahxsanders
left a comment
sarahxsanders
left a comment
There was a problem hiding this comment.
I built three simple apps to test each mode and they are all working/sending events to PostHog using your updated docs 💪 NICE
contents/docs/libraries/react-router/react-router-v7-framework-mode.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/_snippets/step-identify-user.mdx
Outdated
Show resolved
Hide resolved
contents/docs/libraries/react-router/react-router-v7-framework-mode.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah Sanders <88458517+sarahxsanders@users.noreply.github.com> Co-authored-by: Edwin Lim <edwin@posthog.com>
Contributor
Author
|
Thanks for the review folks <3 |
sarahxsanders
added a commit
that referenced
this pull request
Jan 26, 2026
* React Router docs * Apply suggestions from code review Co-authored-by: Sarah Sanders <88458517+sarahxsanders@users.noreply.github.com> Co-authored-by: Edwin Lim <edwin@posthog.com> * tweaks * Logos --------- Co-authored-by: Sarah Sanders <88458517+sarahxsanders@users.noreply.github.com> Co-authored-by: Edwin Lim <edwin@posthog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These are docs for React Router. All the React Router modes are very very very similar with subtle differences. I opted to:
🙏 It's a difficult review, thanks in advance
See examples repo PR for examples