perf: Enable property group optimizations for all new teams by default #25010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
New teams still use the slower path even though they don't have any data that needs backfilling.
Changes
This changes the default value of
modifiers
so that all teams use the new path (see: #24152, #24171, #24381, #24897 for details.)This could also be done with a feature flag but this has a couple advantages:
modifiers
in production for this, so change is minimal and avoids adding new layers of configuration (like what happened with the PoE rollout)It does have some disadvantages though, too:
I couldn't really make up my mind on which approach was "best" so just defaulted to the least impact change since the likelihood that we'll need a kill switch seems minimal (we've been testing this for a while — and worst case we can just run an
UPDATE
to drop the modifier for all teams if we have to) and most if not all teams should be able to be migrated to this in the coming days. (After this is merged, I'm planning on updating all teams that were created after we started writing events with property groups to use this optimization, in fact.)Does this work well for both Cloud and self-hosted?
Yes: see above, this turns it on for new projects in self-hosted as well.
How did you test this code?
See updated snapshots.