Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): intercom destination update #27227

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Jan 2, 2025

Problem

missing features

Changes

  • added oauth authentication
  • added template to update contacts
  • updated the send event template to include properties
  • migrated users off the legacy plugin (US & EU) removed the legacy to hog migrator
  • get intercom oauth app approved
  • added tests
  • add oauth vars to cloud https://github.com/PostHog/charts/pull/2860
  • add migration for old template-id

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Size Change: 0 B

Total Size: 9.73 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 9.73 MB

compressed-size-action

@MarconLP MarconLP marked this pull request as ready for review January 14, 2025 14:32
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@MarconLP MarconLP added waiting Prevents stale-bot from marking the PR as stale. and removed stale labels Jan 24, 2025
@MarconLP MarconLP requested a review from benjackwhite March 3, 2025 15:32
@MarconLP MarconLP removed the waiting Prevents stale-bot from marking the PR as stale. label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants