feat(cdp): Mini purge of old ingesters #29341
Open
+508
−1,320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Mini purge of old ingesters
This PR removes deprecated ingestion systems from the plugin server, focusing on cleaning up old ingestion modes and their corresponding files that are no longer in use.
- Removed several
PluginServerModeentries includingingestion,ingestion_overflow,ingestion_historical,events_ingestion, andanalytics_ingestion - Deleted four ingestion consumer files:
analytics-events-ingestion-consumer.ts,analytics-events-ingestion-overflow-consumer.ts,analytics-events-ingestion-historical-consumer.ts, andevents-ingestion-consumer.ts - Updated
PROCESS_EVENT_CAPABILITIESinworker/vm/capabilities.tsto only includeingestionV2andingestionV2Combined - Modified all tests to use
ingestionV2instead of the deprecated ingestion capabilities - Removed corresponding test files for the deleted ingestion consumers
16 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
12
to
+13
| test('gives the right value for ingestion -> PluginServerMode.plugins_ingestion', () => { | ||
| expect(stringToPluginServerMode['ingestion']).toEqual(PluginServerMode.ingestion) | ||
| expect(stringToPluginServerMode['ingestion-v2']).toEqual(PluginServerMode.ingestion_v2) |
There was a problem hiding this comment.
style: The test description still mentions 'ingestion -> PluginServerMode.plugins_ingestion' but is actually testing 'ingestion-v2 -> PluginServerMode.ingestion_v2'
Suggested change
| test('gives the right value for ingestion -> PluginServerMode.plugins_ingestion', () => { | |
| expect(stringToPluginServerMode['ingestion']).toEqual(PluginServerMode.ingestion) | |
| expect(stringToPluginServerMode['ingestion-v2']).toEqual(PluginServerMode.ingestion_v2) | |
| test('gives the right value for ingestion-v2 -> PluginServerMode.ingestion_v2', () => { | |
| expect(stringToPluginServerMode['ingestion-v2']).toEqual(PluginServerMode.ingestion_v2) |
benjackwhite
commented
Feb 28, 2025
There was a problem hiding this comment.
These tests have all been replaced by the ingestion consumer tests with snapshots confirming things working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're no longer using the old ingesters. Time to remove them and make sure all tests are pointing at new stuff
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?