-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: better queue #29353
chore: better queue #29353
Conversation
pauldambra
commented
Feb 28, 2025
•
edited
Loading
edited
- easier to dashboard if this starting task is on a specific worker too
- include previous result if present
- add tags to errors to make them easier to find
- run the process for any team below some set max id instead of an explicit allowlist (since we have a flag in the UI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies the ee_count_items_in_playlists
task to use the SESSION_REPLAY_GENERAL
queue instead of the default Celery queue.
- Added
queue=CeleryQueue.SESSION_REPLAY_GENERAL.value
parameter to the@shared_task
decorator foree_count_items_in_playlists
- This change routes the playlist counting task to workers dedicated to session replay operations
- Improves monitoring capabilities by isolating this task to a specific worker queue
- Aligns with other session replay tasks like
replay_count_metrics
which already use this queue - Makes performance tracking and dashboarding easier by separating this task from the general queue
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"work on my machine"