feat: Attempt to display non-zero value on Web Vitals #29358
+45
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than blindly displaying the last Web Vitals value, let's instead display the last non-zero value in an effort to avoid display zero just after midnight when the last period has no data This isn't true for CLS because well-optimized sites will actually have a 0 value, so let's do 0 for them
rafaeelaudibert
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves Web Vitals metrics display by showing the last non-zero value for most metrics (except CLS where zero is valid) to avoid misleading zeros when recent data is missing.
- Modified
getMetricinfrontend/src/queries/nodes/WebVitals/definitions.tsto return the last non-zero value for INP, LCP, and FCP metrics while preserving zero values for CLS - Added explanatory text below the metrics grid stating "Metrics above are from the last day in the selected time range" to provide context
- Wrapped the WebVitalsTab components in a flex container with proper styling for better layout organization
- Implemented special handling for CLS metric to show zero values since they indicate good performance
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: 0 B Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
Note that the values are from the last day in the period selected, this wasn't clear enough before, some people thought it was the average - but that just doesn't make any sense Update UI snapshots for `chromium` (3) Update UI snapshots for `chromium` (1)
rafaeelaudibert
force-pushed
the
display-slightly-more-useful-number-at-the-top-for-web-vitals-if-zero
branch
from
ad7ddb8 to
6779b45
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than blindly displaying the last Web Vitals value, let's instead display the last non-zero value in an effort to avoid display zero just after midnight when the last period has no data
This isn't true for CLS because well-optimized sites will actually have a 0 value, so let's do 0 for them
Also, display a slightly-too-prominent-but-intended-to-reduce-confusion message under those cards
