fix(retention): fix showing mean #29374
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes a bug in the retention table's mean calculation by adding a boundary check for column indices.
- Added a condition in
frontend/src/scenes/retention/RetentionTable.tsxto prevent accessing out-of-bounds indices when calculating mean percentages - The fix handles cases where some retention cohorts have fewer data points than others, preventing potential errors
- The change ensures the mean calculation properly skips columns that don't exist for certain rows
- Improves robustness of the retention table when displaying mean values across cohorts with varying data availability
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
thmsobrmlr
approved these changes
Feb 28, 2025
|
Size Change: 0 B Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://posthog.slack.com/archives/C0368RPHLQH/p1740768734994999
Changes
Check length before showing mean
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested locally