chore(flags): remove decide request log now that django logs showing up in Loki #29375
+3
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havenbarnes
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR removes the decide request logging functionality that's now redundant due to the new posthog-decide-django service ingesting standard Django logs through Loki.
- Removed
DECIDE_REQUEST_LOGGING_SAMPLING_RATEsetting fromposthog/settings/web.py - Removed sampled logging functionality from
posthog/api/decide.py - Removed
is_request_sampled_for_loggingparameter from function signatures in decide.py - Core functionality of the decide endpoint remains unchanged
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We no longer need this now that the new
posthog-decide-djangoservice is ingesting standard djangorequest_startedandrequest_finishedlogs: https://grafana.prod-us.posthog.dev/a/grafana-lokiexplore-app/explore/service/posthog-decide-django/logs?patterns=%5B%5D&from=now-15m&to=now&var-ds=P8E80F9AEF21F6940&var-filters=service_name%7C%3D%7Cposthog-decide-django&var-fields=team_id%7C%3D%7C__CV%CE%A9__%7B%22value%22:%229291%22__gfc__%22parser%22:%22mixed%22%7D,9291&var-levels=&var-metadata=&var-patterns=&var-lineFilterV2=&var-lineFilters=&urlColumns=%5B%5D&visualizationType=%22logs%22&displayedFields=%5B%5D&timezone=browser&var-all-fields=team_id%7C%3D%7C__CV%CE%A9__%7B%22value%22:%229291%22__gfc__%22parser%22:%22mixed%22%7D,9291&sortOrder=%22Descending%22&wrapLogMessage=falseChanges
Remove sampled logs
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Made sure decide still succeeds after this change, existing tests should also cover this