chore: update project tree scroll to current ID context menu, top bar

.cursorignore

@@ -0,0 +1 @@
+.env

.flox/env/manifest.toml

@@ -45,6 +45,7 @@ nodemon = { pkg-path = "nodemon" }
 xmlsec = { pkg-path = "xmlsec", version = "1.3.6" }
 openssl = { pkg-path = "openssl", version = "3.4.1", pkg-group = "openssl" }
 cmake = { pkg-path = "cmake", version = "3.31.5", pkg-group = "cmake" }
+freetds = { pkg-path = "freetds" }
 
 # Set environment variables in the `[vars]` section. These variables may not
 # reference one another, and are added to the environment without first
@@ -54,6 +55,9 @@ cmake = { pkg-path = "cmake", version = "3.31.5", pkg-group = "cmake" }
 DEBUG = "1"
 POSTHOG_SKIP_MIGRATION_CHECKS = "1"
 DIRENV_LOG_FORMAT = "" # Disable direnv activation logging (in case direnv is present)
+OPENSSL_ROOT_DIR = "$FLOX_ENV"
+OPENSSL_LIB_DIR = "$FLOX_ENV/lib"
+OPENSSL_INCLUDE_DIR = "$FLOX_ENV/include"
 LDFLAGS="-L$FLOX_ENV/lib"
 CPPFLAGS="-I$FLOX_ENV/include"
 
@@ -90,7 +94,7 @@ echo -e "Python interpreter path, for your code editor: \033[33m.flox/cache/venv
 source "$PYTHON_DIR/bin/activate"
 
 # Install Python dependencies (this is practically instant thanks to uv)
-uv pip install -q -r requirements.txt -r requirements-dev.txt
+uv pip install -q --no-binary=pymssql -r requirements.txt -r requirements-dev.txt
 
 # Install top-level Node dependencies (only if not present all yet, because this takes almost a second even with pnpm)
 # This also sets up pre-commit hooks via Husky

.github/workflows/rust-docker-build.yml

@@ -102,6 +102,13 @@ jobs:
               id: buildx
               uses: docker/setup-buildx-action@v2
 
+            - name: Retrieve sccache configuration
+              id: sccache
+              run: |
+                  echo "endpoint=$SCCACHE_WEBDAV_ENDPOINT" >> "$GITHUB_OUTPUT"
+                  echo "::add-mask::$SCCACHE_WEBDAV_TOKEN"
+                  echo "token=$SCCACHE_WEBDAV_TOKEN" >> "$GITHUB_OUTPUT"
+
             - name: Build and push image
               id: docker_build
               uses: depot/build-push-action@v1
@@ -114,8 +121,8 @@ jobs:
                   platforms: linux/arm64,linux/amd64
                   build-args: BIN=${{ matrix.image }}
                   secrets: |
-                      SCCACHE_WEBDAV_ENDPOINT=${{ env.SCCACHE_WEBDAV_ENDPOINT }}
-                      SCCACHE_WEBDAV_TOKEN=${{ env.SCCACHE_WEBDAV_TOKEN }}
+                      SCCACHE_WEBDAV_ENDPOINT=${{ steps.sccache.outputs.endpoint }}
+                      SCCACHE_WEBDAV_TOKEN=${{ steps.sccache.outputs.token }}
 
             - name: Container image digest
               id: digest

common/hogvm/__tests__/__snapshots__/stl.hoge

@@ -44,22 +44,23 @@
 "print", 1, 35, 32, "-- string/array --", 2, "print", 1, 35, 32, "a", 32, "a", 32, "b", 32, "c", 2, "tuple", 3, 2, "in",
 2, 32, "z", 32, "a", 32, "b", 32, "c", 2, "tuple", 3, 2, "in", 2, 2, "print", 2, 35, 32, "a", 32, "a", 32, "b", 32, "c",
 43, 3, 2, "in", 2, 32, "z", 32, "a", 32, "b", 32, "c", 43, 3, 2, "in", 2, 2, "print", 2, 35, 32, "hello", 32, "he", 2,
-"startsWith", 2, 32, "abcdef", 33, 2, 33, 3, 2, "substring", 3, 2, "print", 2, 35, 31, 31, 32, "firstNonNull", 2,
-"coalesce", 3, 32, "notNull", 2, "assumeNotNull", 1, 2, "print", 2, 35, 32, "", 2, "print", 1, 35, 32, "-- date --", 2,
-"print", 1, 35, 32, "2024-12-18T00:00:00Z", 2, "toDateTime", 1, 2, "toYear", 1, 32, "2024-12-18T00:00:00Z", 2,
-"toDateTime", 1, 2, "toMonth", 1, 2, "print", 2, 35, 2, "now", 0, 2, "typeof", 1, 2, "print", 1, 35, 32,
-"2024-12-18T11:11:11Z", 2, "toDateTime", 1, 2, "toStartOfDay", 1, 32, "2024-12-18T11:11:11Z", 2, "toDateTime", 1, 2,
-"toStartOfWeek", 1, 2, "print", 2, 35, 32, "2024-12-18T00:00:00Z", 2, "toDateTime", 1, 2, "toYYYYMM", 1, 2, "print", 1,
-35, 32, "day", 33, 1, 32, "2024-12-18", 2, "toDate", 1, 2, "dateAdd", 3, 32, "day", 32, "2024-12-18", 2, "toDate", 1,
-32, "day", 33, 5, 32, "2024-12-18", 2, "toDate", 1, 2, "dateAdd", 3, 2, "dateDiff", 3, 2, "print", 2, 35, 32, "day", 32,
-"2024-12-18T12:34:56Z", 2, "toDateTime", 1, 2, "dateTrunc", 2, 2, "print", 1, 35, 32, "2024-12-18", 2, "toDate", 1, 33,
-3, 2, "addDays", 2, 2, "print", 1, 35, 33, 5, 2, "toIntervalDay", 1, 33, 2, 2, "toIntervalMonth", 1, 2, "print", 2, 35,
-2, "today", 0, 2, "typeof", 1, 2, "print", 1, 35, 32, "", 2, "print", 1, 35, 32, "-- json --", 2, "print", 1, 35, 32,
-"{\"a\":123.1}", 32, "a", 2, "JSONExtractInt", 2, 2, "jsonStringify", 1, 32, "{\"a\":\"hello\"}", 32, "a", 2,
-"JSONExtractInt", 2, 2, "jsonStringify", 1, 2, "print", 2, 35, 32, "{\"a\":123.1}", 32, "a", 2, "JSONExtractFloat", 2,
-2, "jsonStringify", 1, 32, "{\"a\":\"hello\"}", 32, "a", 2, "JSONExtractFloat", 2, 2, "jsonStringify", 1, 2, "print", 2,
-35, 32, "{\"a\":123.1}", 32, "a", 2, "JSONExtractString", 2, 2, "jsonStringify", 1, 32, "{\"a\":\"hello\"}", 32, "a", 2,
-"JSONExtractString", 2, 2, "jsonStringify", 1, 2, "print", 2, 35, 32, "{\"a\":123}", 32, "a", 2, "JSONExtractArrayRaw",
-2, 2, "jsonStringify", 1, 32, "{\"a\":\"hello\"}", 32, "a", 2, "JSONExtractArrayRaw", 2, 2, "jsonStringify", 1, 2,
-"print", 2, 35, 32, "{\"a\":[]}", 32, "a", 2, "JSONExtractArrayRaw", 2, 2, "jsonStringify", 1, 32,
-"{\"a\":[\"hello\"]}", 32, "a", 2, "JSONExtractArrayRaw", 2, 2, "jsonStringify", 1, 2, "print", 2, 35]
+"startsWith", 2, 32, "abcdef", 33, 2, 33, 3, 2, "substring", 3, 2, "print", 2, 35, 32, "abcdef", 33, 2, 2, "substring",
+2, 2, "print", 1, 35, 31, 31, 32, "firstNonNull", 2, "coalesce", 3, 32, "notNull", 2, "assumeNotNull", 1, 2, "print", 2,
+35, 32, "", 2, "print", 1, 35, 32, "-- date --", 2, "print", 1, 35, 32, "2024-12-18T00:00:00Z", 2, "toDateTime", 1, 2,
+"toYear", 1, 32, "2024-12-18T00:00:00Z", 2, "toDateTime", 1, 2, "toMonth", 1, 2, "print", 2, 35, 2, "now", 0, 2,
+"typeof", 1, 2, "print", 1, 35, 32, "2024-12-18T11:11:11Z", 2, "toDateTime", 1, 2, "toStartOfDay", 1, 32,
+"2024-12-18T11:11:11Z", 2, "toDateTime", 1, 2, "toStartOfWeek", 1, 2, "print", 2, 35, 32, "2024-12-18T00:00:00Z", 2,
+"toDateTime", 1, 2, "toYYYYMM", 1, 2, "print", 1, 35, 32, "day", 33, 1, 32, "2024-12-18", 2, "toDate", 1, 2, "dateAdd",
+3, 32, "day", 32, "2024-12-18", 2, "toDate", 1, 32, "day", 33, 5, 32, "2024-12-18", 2, "toDate", 1, 2, "dateAdd", 3, 2,
+"dateDiff", 3, 2, "print", 2, 35, 32, "day", 32, "2024-12-18T12:34:56Z", 2, "toDateTime", 1, 2, "dateTrunc", 2, 2,
+"print", 1, 35, 32, "2024-12-18", 2, "toDate", 1, 33, 3, 2, "addDays", 2, 2, "print", 1, 35, 33, 5, 2, "toIntervalDay",
+1, 33, 2, 2, "toIntervalMonth", 1, 2, "print", 2, 35, 2, "today", 0, 2, "typeof", 1, 2, "print", 1, 35, 32, "", 2,
+"print", 1, 35, 32, "-- json --", 2, "print", 1, 35, 32, "{\"a\":123.1}", 32, "a", 2, "JSONExtractInt", 2, 2,
+"jsonStringify", 1, 32, "{\"a\":\"hello\"}", 32, "a", 2, "JSONExtractInt", 2, 2, "jsonStringify", 1, 2, "print", 2, 35,
+32, "{\"a\":123.1}", 32, "a", 2, "JSONExtractFloat", 2, 2, "jsonStringify", 1, 32, "{\"a\":\"hello\"}", 32, "a", 2,
+"JSONExtractFloat", 2, 2, "jsonStringify", 1, 2, "print", 2, 35, 32, "{\"a\":123.1}", 32, "a", 2, "JSONExtractString",
+2, 2, "jsonStringify", 1, 32, "{\"a\":\"hello\"}", 32, "a", 2, "JSONExtractString", 2, 2, "jsonStringify", 1, 2,
+"print", 2, 35, 32, "{\"a\":123}", 32, "a", 2, "JSONExtractArrayRaw", 2, 2, "jsonStringify", 1, 32, "{\"a\":\"hello\"}",
+32, "a", 2, "JSONExtractArrayRaw", 2, 2, "jsonStringify", 1, 2, "print", 2, 35, 32, "{\"a\":[]}", 32, "a", 2,
+"JSONExtractArrayRaw", 2, 2, "jsonStringify", 1, 32, "{\"a\":[\"hello\"]}", 32, "a", 2, "JSONExtractArrayRaw", 2, 2,
+"jsonStringify", 1, 2, "print", 2, 35]

common/hogvm/__tests__/__snapshots__/stl.js

@@ -61,9 +61,10 @@ function toIntervalMonth(val) { return __toHogInterval(val, 'month') }
 function toIntervalDay(val) { return __toHogInterval(val, 'day') }
 function toDateTime (input, zone) { return __toDateTime(input, zone) }
 function toDate (input) { return __toDate(input) }
-function substring(s, start, length) {
+function substring(s, start, optionalLength) {
     if (typeof s !== 'string') return '';
     const startIdx = start - 1;
+    const length = typeof optionalLength === 'number' ? optionalLength : s.length - startIdx;
     if (startIdx < 0 || length < 0) return '';
     const endIdx = startIdx + length;
     return startIdx < s.length ? s.slice(startIdx, endIdx) : '';
@@ -531,6 +532,7 @@ print("-- string/array --");
 print(__x_in("a", tuple("a", "b", "c")), __x_in("z", tuple("a", "b", "c")));
 print(__x_in("a", ["a", "b", "c"]), __x_in("z", ["a", "b", "c"]));
 print(startsWith("hello", "he"), substring("abcdef", 2, 3));
+print(substring("abcdef", 2));
 print(coalesce(null, null, "firstNonNull"), assumeNotNull("notNull"));
 print("");
 print("-- date --");

common/hogvm/__tests__/__snapshots__/stl.stdout

@@ -89,6 +89,7 @@ one
 true false
 true false
 true bcd
+bcdef
 firstNonNull notNull
 
 -- date --

common/hogvm/__tests__/stl.hog

@@ -89,6 +89,7 @@ print('-- string/array --')
 print(in('a', tuple('a','b','c')), in('z', tuple('a','b','c')))
 print(in('a', ['a','b','c']), in('z', ['a','b','c']))
 print(startsWith('hello','he'), substring('abcdef',2,3))
+print(substring('abcdef',2))
 print(coalesce(null, null, 'firstNonNull'), assumeNotNull('notNull'))
 print('')
 print('-- date --')

common/hogvm/python/stl/__init__.py

@@ -718,10 +718,10 @@ def substring(args: list[Any], team: Optional["Team"], stdout: Optional[list[str
     # start is 1-based.
     s = args[0]
     start = args[1]
-    length = args[2]
     if not isinstance(s, str):
         return ""
     start_idx = start - 1
+    length = args[2] if len(args) > 2 else len(s) - start_idx
     if start_idx < 0 or length < 0:
         return ""
     end_idx = start_idx + length
@@ -1060,7 +1060,7 @@ def JSONExtractString(args: list[Any], team: Optional["Team"], stdout: Optional[
     "range": STLFunction(fn=range_fn, minArgs=1, maxArgs=2),
     "round": STLFunction(fn=round_fn, minArgs=1, maxArgs=1),
     "startsWith": STLFunction(fn=startsWith, minArgs=2, maxArgs=2),
-    "substring": STLFunction(fn=substring, minArgs=3, maxArgs=3),
+    "substring": STLFunction(fn=substring, minArgs=2, maxArgs=3),
     "toIntervalDay": STLFunction(fn=toIntervalDay, minArgs=1, maxArgs=1),
     "toIntervalHour": STLFunction(fn=toIntervalHour, minArgs=1, maxArgs=1),
     "toIntervalMinute": STLFunction(fn=toIntervalMinute, minArgs=1, maxArgs=1),

common/hogvm/typescript/src/stl/stl.ts

@@ -316,11 +316,12 @@ function startsWithFn([str, prefix]: any[]): boolean {
     return typeof str === 'string' && typeof prefix === 'string' && str.startsWith(prefix)
 }
 
-function substringFn([s, start, length]: any[]): string {
+function substringFn([s, start, optionalLength]: any[]): string {
     if (typeof s !== 'string') {
         return ''
     }
     const startIdx = start - 1
+    const length = typeof optionalLength === 'number' ? optionalLength : s.length - startIdx
     if (startIdx < 0 || length < 0) {
         return ''
     }
@@ -1259,7 +1260,7 @@ export const STL: Record<string, STLFunction> = {
     range: { fn: rangeFn, minArgs: 1, maxArgs: 2 },
     round: { fn: roundFn, minArgs: 1, maxArgs: 1 },
     startsWith: { fn: startsWithFn, minArgs: 2, maxArgs: 2 },
-    substring: { fn: substringFn, minArgs: 3, maxArgs: 3 },
+    substring: { fn: substringFn, minArgs: 2, maxArgs: 3 },
     toIntervalDay: { fn: toIntervalDayFn, minArgs: 1, maxArgs: 1 },
     toIntervalHour: { fn: toIntervalHourFn, minArgs: 1, maxArgs: 1 },
     toIntervalMinute: { fn: toIntervalMinuteFn, minArgs: 1, maxArgs: 1 },

ee/api/ee_event_definition.py

@@ -1,21 +1,21 @@
+from typing import cast
+
+import posthoganalytics
 from django.utils import timezone
+from loginas.utils import is_impersonated_session
 from rest_framework import serializers
 
 from ee.models.event_definition import EnterpriseEventDefinition
 from posthog.api.shared import UserBasicSerializer
 from posthog.api.tagged_item import TaggedItemSerializerMixin
+from posthog.event_usage import groups
+from posthog.models import User
 from posthog.models.activity_logging.activity_log import (
+    Detail,
     dict_changes_between,
     log_activity,
-    Detail,
 )
 
-from loginas.utils import is_impersonated_session
-from typing import cast
-import posthoganalytics
-from posthog.event_usage import groups
-from posthog.models import User
-
 
 class EnterpriseEventDefinitionSerializer(TaggedItemSerializerMixin, serializers.ModelSerializer):
     updated_by = UserBasicSerializer(read_only=True)
@@ -44,6 +44,7 @@ class Meta:
             "verified",
             "verified_at",
             "verified_by",
+            "hidden",
             # Action fields
             "is_action",
             "action_id",
@@ -69,9 +70,27 @@ class Meta:
             "created_by",
         ]
 
+    def validate(self, data):
+        validated_data = super().validate(data)
+
+        if "hidden" in validated_data and "verified" in validated_data:
+            if validated_data["hidden"] and validated_data["verified"]:
+                raise serializers.ValidationError("An event cannot be both hidden and verified")
+
+        return validated_data
+
     def update(self, event_definition: EnterpriseEventDefinition, validated_data):
         validated_data["updated_by"] = self.context["request"].user
 
+        # If setting hidden=True, ensure verified becomes false
+        if validated_data.get("hidden", False):
+            validated_data["verified"] = False
+            validated_data["verified_by"] = None
+            validated_data["verified_at"] = None
+        # If setting verified=True, ensure hidden becomes false
+        elif validated_data.get("verified", False):
+            validated_data["hidden"] = False
+
         if "verified" in validated_data:
             if validated_data["verified"] and not event_definition.verified:
                 # Verify event only if previously unverified

ee/api/ee_property_definition.py

@@ -1,15 +1,16 @@
-from rest_framework import serializers
 from django.utils import timezone
+from loginas.utils import is_impersonated_session
+from rest_framework import serializers
+
 from ee.models.property_definition import EnterprisePropertyDefinition
 from posthog.api.shared import UserBasicSerializer
 from posthog.api.tagged_item import TaggedItemSerializerMixin
 from posthog.models import PropertyDefinition
 from posthog.models.activity_logging.activity_log import (
+    Detail,
     dict_changes_between,
     log_activity,
-    Detail,
 )
-from loginas.utils import is_impersonated_session
 
 
 class EnterprisePropertyDefinitionSerializer(TaggedItemSerializerMixin, serializers.ModelSerializer):
@@ -31,6 +32,7 @@ class Meta:
             "verified",
             "verified_at",
             "verified_by",
+            "hidden",
         )
         read_only_fields = [
             "id",
@@ -41,7 +43,32 @@ class Meta:
             "verified_by",
         ]
 
-    def update(self, property_definition: EnterprisePropertyDefinition, validated_data):
+    def validate(self, data):
+        validated_data = super().validate(data)
+
+        if "hidden" in validated_data and "verified" in validated_data:
+            if validated_data["hidden"] and validated_data["verified"]:
+                raise serializers.ValidationError("A property cannot be both hidden and verified")
+
+        # If setting hidden=True, ensure verified becomes false
+        if validated_data.get("hidden", False):
+            validated_data["verified"] = False
+        # If setting verified=True, ensure hidden becomes false
+        elif validated_data.get("verified", False):
+            validated_data["hidden"] = False
+
+        return validated_data
+
+    def update(self, property_definition: EnterprisePropertyDefinition, validated_data: dict):
+        # If setting hidden=True, ensure verified becomes false
+        if validated_data.get("hidden", False):
+            validated_data["verified"] = False
+            validated_data["verified_by"] = None
+            validated_data["verified_at"] = None
+        # If setting verified=True, ensure hidden becomes false
+        elif validated_data.get("verified", False):
+            validated_data["hidden"] = False
+
         validated_data["updated_by"] = self.context["request"].user
         if "property_type" in validated_data:
             if validated_data["property_type"] == "Numeric":

ee/api/integration.py

@@ -22,6 +22,14 @@ class PublicIntegrationViewSet(viewsets.GenericViewSet):
     authentication_classes = []
     permission_classes = []
 
+    @action(methods=["POST"], detail=False, url_path="slack/interactivity-callback")
+    def slack_interactivity_callback(self, request: Request, *args: Any, **kwargs: Any) -> Response:
+        # This is an empty endpoint for the Slack interactivity callback.
+        # We don't verify the request, as we don't do anything with the submitted data.
+        # We only use it to supress the warnings when users press buttons in Slack messages.
+        # In case we decide to do something with it, please add the verification process here.
+        return Response({"status": "ok"})
+
     @action(methods=["POST"], detail=False, url_path="slack/events")
     def slack_events(self, request: Request, *args: Any, **kwargs: Any) -> Response:
         try: