chore: update project tree scroll to current ID context menu, top bar #29427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the project tree component with improved state persistence, context menus, and drag-and-drop functionality.
- Added context menu functionality to tree items using a new
ContextMenucomponent based on Radix UI primitives - Implemented state persistence to maintain selected tree items across page refreshes and scroll to active items
- Replaced command key requirement for drag-and-drop with intuitive visual indicators and right-click context menu
- Added a dismissable help banner explaining navigation features and a top bar with edit/save/cancel controls
- Updated styling with new highlight variables and z-index settings to support context menus and visual feedback
8 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/layout/navigation-3000/components/ProjectTree/ProjectTree.tsx
Outdated
Show resolved
Hide resolved
| @@ -463,8 +504,10 @@ const LemonTree = forwardRef<HTMLDivElement, LemonTreeProps>( | |||
| // Update focusedId when clicking | |||
| setFocusedId(item?.id) | |||
|
|
|||
| const isFolder = item?.children && item?.children?.length >= 0 | |||
There was a problem hiding this comment.
style: The condition item?.children && item?.children?.length >= 0 will always be true if item.children exists, even if it's an empty array. Consider using item?.children !== undefined instead for clarity.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…jectTree.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
adamleithp
changed the title
|
Size Change: 0 B Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an project tree/lemon tree item was clicked we went to that URL, but when we refreshed, we'd lose that context in the tree.
Also, drag and drop (currently) is initiated by holding command key/use context menu, which is not obvious, so I added a dismissable banner to help users know what's going on.
Changes
Does this work well for both Cloud and self-hosted?
It should
How did you test this code?
Locally