Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove fully rolled-out Web Analytics FFs #29428

Merged
merged 9 commits into from
Mar 3, 2025

Conversation

rafaeelaudibert
Copy link
Member

Trivial removal of Web Analytics FFs, these are all 100% enabled for a while

@rafaeelaudibert
Copy link
Member Author

@robbie-c Take 2 on that PR of mine, that got way too many conflicts so I created a new one

@rafaeelaudibert rafaeelaudibert changed the title Remove fully rolled-out Web Analytics FFs chore: Remove fully rolled-out Web Analytics FFs Mar 3, 2025
Copy link

promptless bot commented Mar 3, 2025

✅ No documentation updates required.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes fully rolled-out Web Analytics feature flags that have been 100% enabled for some time, simplifying the codebase by eliminating conditional logic.

  • Removes six feature flags from lib/constants.tsx: WEB_VITALS, WEB_VITALS_TOOLBAR, PATH_CLEANING_AI_REGEX, WEB_ANALYTICS_TABLE_SORTING, WEB_ANALYTICS_DOMAIN_DROPDOWN, and ONBOARDING_AUTHORIZED_DOMAINS
  • Simplifies Toolbar.scss by standardizing the toolbar width to 334px and removing conditional width classes for web vitals
  • Removes conditional rendering in WebAnalyticsFilters.tsx to always show domain dropdown and device toggle components
  • Updates ToolbarLaunch.tsx to permanently include Web Vitals in the features list without feature flag checks
  • Removes feature flag wrappers from PathRegexModal.tsx to directly render AI regex helper functionality

12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Size Change: -522 B (-0.01%)

Total Size: 9.73 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 9.73 MB -522 B (-0.01%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

10 snapshot changes in total. 0 added, 10 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@rafaeelaudibert rafaeelaudibert force-pushed the remove-web-analytics-ffs branch from 431e075 to 101da0d Compare March 3, 2025 19:29
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@rafaeelaudibert rafaeelaudibert merged commit dad6420 into master Mar 3, 2025
91 of 96 checks passed
@rafaeelaudibert rafaeelaudibert deleted the remove-web-analytics-ffs branch March 3, 2025 20:20
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (wasn't pushed!)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants