-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove fully rolled-out Web Analytics FFs #29428
Conversation
@robbie-c Take 2 on that PR of mine, that got way too many conflicts so I created a new one |
✅ No documentation updates required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR removes fully rolled-out Web Analytics feature flags that have been 100% enabled for some time, simplifying the codebase by eliminating conditional logic.
- Removes six feature flags from
lib/constants.tsx
: WEB_VITALS, WEB_VITALS_TOOLBAR, PATH_CLEANING_AI_REGEX, WEB_ANALYTICS_TABLE_SORTING, WEB_ANALYTICS_DOMAIN_DROPDOWN, and ONBOARDING_AUTHORIZED_DOMAINS - Simplifies
Toolbar.scss
by standardizing the toolbar width to 334px and removing conditional width classes for web vitals - Removes conditional rendering in
WebAnalyticsFilters.tsx
to always show domain dropdown and device toggle components - Updates
ToolbarLaunch.tsx
to permanently include Web Vitals in the features list without feature flag checks - Removes feature flag wrappers from
PathRegexModal.tsx
to directly render AI regex helper functionality
12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Size Change: -522 B (-0.01%) Total Size: 9.73 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated10 snapshot changes in total. 0 added, 10 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
This was wonky, it's fixed now
431e075
to
101da0d
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Trivial removal of Web Analytics FFs, these are all 100% enabled for a while