Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove ph-no-capture class from canvas elements #29437

Merged
merged 4 commits into from
Mar 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 0 additions & 2 deletions frontend/src/queries/nodes/DataTable/renderColumn.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ export function renderColumn(
: '#'
return (
<Link
className="ph-no-capture"
to={newUrl}
onClick={(e) => {
e.preventDefault()
Expand Down Expand Up @@ -207,7 +206,6 @@ export function renderColumn(
: '#'
return (
<Link
className="ph-no-capture"
to={newUrl}
onClick={(e) => {
e.preventDefault()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export function InsightVizDisplay({
{/* These are filters that are reused between insight features. They each have generic logic that updates the url */}
<div
className={clsx(
`InsightVizDisplay InsightVizDisplay--type-${activeView.toLowerCase()} ph-no-capture`,
`InsightVizDisplay InsightVizDisplay--type-${activeView.toLowerCase()}`,
!embedded && 'border rounded bg-surface-primary'
)}
data-attr="insights-graph"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/annotations/Annotations.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function Annotations(): JSX.Element {
width: '30%',
render: function RenderAnnotation(_, annotation: AnnotationType): JSX.Element {
return (
<div className="ph-no-capture font-semibold">
<div className="font-semibold">
<Link subtle to={urls.annotation(annotation.id)}>
{annotation.content}
</Link>
Expand Down
1 change: 0 additions & 1 deletion frontend/src/scenes/cohorts/Cohorts.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ export function Cohorts(): JSX.Element {
{
title: 'Name',
dataIndex: 'name',
className: 'ph-no-capture',
width: '30%',
sorter: (a, b) => (a.name || '').localeCompare(b.name || ''),
render: function Render(name, { id, description }) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ export function InsightTooltip({
dataSource={dataSource.slice(0, rowCutoff)}
columns={columns}
rowKey="id"
className="ph-no-capture"
uppercaseHeader={false}
rowRibbonColor={hideColorCol ? undefined : (datum: SeriesDatum) => datum.color || null}
showHeader={showHeader}
Expand Down
Loading