feat: apply to_tsvector to the filtered columns when a fts operator is used
#3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenceisla
force-pushed
the
feat-totsv
branch
2 times, most recently
from
b9cee18 to
b8f8db2
Compare
laurenceisla
force-pushed
the
feat-totsv
branch
from
b8f8db2 to
5e61a05
Compare
laurenceisla
commented
Jan 17, 2025
laurenceisla
force-pushed
the
feat-totsv
branch
from
5e61a05 to
42b02b6
Compare
laurenceisla
commented
Jan 17, 2025
Comment on lines
289
to
+290
| res = fromMaybe (unknownField fn jp) $ HM.lookup qi tables >>= | ||
| Just . flip resolveTableFieldName fn | ||
| Just . (\t -> resolveTableFieldName t fn toTsV) |
There was a problem hiding this comment.
There was a performance concern here: #2255 (comment)
I don't think there will be a difference in performance since it's using this lookup that is already applied for all filters before this PR.
laurenceisla
force-pushed
the
feat-totsv
branch
from
42b02b6 to
846a45c
Compare
laurenceisla
changed the title
to_tsvector to the filtered columns when a fts operator is used
laurenceisla
force-pushed
the
feat-totsv
branch
from
01a52f3 to
01aab5e
Compare
src/PostgREST/Plan/Types.hs
Outdated
| @@ -20,6 +21,7 @@ import PostgREST.SchemaCache.Identifiers (FieldName) | |||
| import Protolude | |||
|
|
|||
| type TransformerProc = Text | |||
| type ToTsVector = Maybe (Maybe Text) | |||
There was a problem hiding this comment.
This is confusing at first glance, why a double Maybe?
There was a problem hiding this comment.
True, I created a new type to make it make sense.
docs/references/api/tables_views.rst
Outdated
| @@ -193,7 +193,7 @@ The :code:`fts` filter mentioned above has a number of options to support flexib | |||
|
|
|||
| curl "http://localhost:3000/tsearch?my_tsv=not.wfts(french).amusant" | |||
|
|
|||
| Using `websearch_to_tsquery` requires PostgreSQL of version at least 11.0 and will raise an error in earlier versions of the database. | |||
| This also works with columns of text and JSON types, converting them to ``tsvector`` accordingly. | |||
There was a problem hiding this comment.
A subsection would be better for this. This way we can also highlight the feature on the release notes.
Maybe "automatic tsvector casting"`, "automatic to_tsvector??
laurenceisla
force-pushed
the
feat-totsv
branch
from
01aab5e to
9bffd08
Compare
… column, only if it's not of tsvector type
laurenceisla
force-pushed
the
feat-totsv
branch
from
9bffd08 to
cb069ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2255
When an
ftsoperator is used, then it appliesto_tsvectorto the filtered column. For example:is equivalent to this in SQL:
If the `totsv` modifier (short for `to_tsvector`) is used for `fts` operators then it applies `to_tsvector` to the filtered column. For example:Is equivalent to this in SQL: