-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor: Isolate unrelated errors in the Error module
#4433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Please note that we are still stuck on the versioning we are currently using, because we still need to support GHC 9.4 for the time being. So there is no quick way forward. Also some other PRs already have code to update hasql, once we get there, for example 612dfec. |
The latest releases of Hasql and the upcoming version is tested to support GHC down to 8.10. So there should be no issue with that. |
Interesting. I would have to look into that again, but I don't think it works with the Nixpkgs-provided GHC 9.4. I think this relates to the fact that Nixpkgs always forces the core libraries in the version that the compiler shipped with. IIRC we'd hit bounds for |
|
Let's check. If any issues come up, they should be easy to fix. Also please notice that this PR is just refactoring and doesn't deal with dependencies. |
This is exclusively a structural refactoring of the
PostgREST.Errormodule, which decouples various errors by distributing them across cohesive modules. It also encapsulates the helper definitions.I've noticed myself needing this refactoring while working on migrating the codebase to the upcoming release of Hasql. After this refactoring that concern is now clearly located under the
PostgREST.Error.PgError.*namespace.