Experimental PowerShell discover extension#1071
Open
Gijsreyn wants to merge 41 commits intoPowerShell:mainfrom
Open
Experimental PowerShell discover extension#1071Gijsreyn wants to merge 41 commits intoPowerShell:mainfrom
Gijsreyn wants to merge 41 commits intoPowerShell:mainfrom
Conversation
Collaborator
Author
|
With PR #1025 around, it might be worthwhile to rename the directories. |
623d593 to
5b7502f
Compare
5b7502f to
991f7ce
Compare
…jsreyn/operation-methods into implement-powershell-discover
6337045 to
f15195a
Compare
Collaborator
michaeltlombardi
left a comment
There was a problem hiding this comment.
A few questions and requests:
- Do I correctly understand that this extension only for resources implemented in PowerShell and excluding Windows PowerShell? If so, do we need a second extension for discovering those resources, or can we handle that in this one? I'm not sure I see an immediate reason for why we can't handle both here, given the manifest has to indicate whether the resource is invoked with
powershellorpwsh. - Can we slightly restructure this script to define (currently empty)
paramblock and put the implementation into theprocessblock? That can help with organization and testing later on. - The current implementation can't run in Windows PowerShell, I think, given the use of
ForEach-Object -Parallel- but we can still discover resources in Windows PowerShell modules.
Collaborator
Author
|
…jsreyn/operation-methods into implement-powershell-discover
Member
|
The WG discussed this and agree to not have WinPS support initially until there is a customer need |
Collaborator
Author
|
@SteveL-MSFT - by any chance, if you have time to review this one, I would appreciate it. |
SteveL-MSFT
requested changes
Oct 7, 2025
…into implement-powershell-discover
Collaborator
Author
|
@SteveL-MSFT - caching added. Took a couple of rounds because of returning nothing. Added this to the docs after discussing with Mikey. |
…jsreyn/operation-methods into implement-powershell-discover
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Implements an optimized approach to discovering PowerShell resources using .NET with parallel processing and direct result synchronization.
The previous approach using Get-ChildItem had unnecessary object overhead and required post-processing with
Where-Object. The same is implied when using a thread-safe collection (ConcurrentBag), which adds unnecessary complexity.PR Context
Fix #913