Skip to content

Conversation

@tgauth
Copy link
Collaborator

@tgauth tgauth commented Nov 4, 2025

PR Summary

  • add back code that was removed starting in V8.9 which prevented the pre-auth child process from being terminated when LoginGraceTime expired, potentially leading to a build-up of orphaned child processes until the corresponding client disconnected
  • update LoginGraceTime pester test

PR Context

@tgauth tgauth requested review from Copilot and vthiebaut10 November 4, 2025 17:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the grace alarm handler behavior on Windows to ensure both session processes exit when LoginGraceTime expires, and includes a minor formatting correction.

  • Added Windows-specific logic to explicitly kill the child process when the login grace period expires
  • Updated test expectations to verify both session processes exit after grace timeout
  • Removed trailing whitespace from a comment

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
sshd-session.c Added Windows-specific grace alarm handler to kill child process via pmonitor PID; removed trailing whitespace from comment
regress/pesterTests/SSHD.Tests.ps1 Updated test assertion to expect both session processes to exit after LoginGraceTime expires

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tgauth
Copy link
Collaborator Author

tgauth commented Nov 4, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@o-sdn-o

This comment was marked as outdated.

@o-sdn-o

This comment was marked as outdated.

@o-sdn-o

This comment was marked as resolved.

@o-sdn-o

This comment was marked as resolved.

@o-sdn-o

This comment was marked as resolved.

send_config_state(int fd, struct sshbuf* conf)
{
/* copied from send_rexec_state() in sshd.c
/* copied from send_rexec_state() in sshd.c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this trailing space from upstream? I would leave it unchanged if that is the case just to reduce discrepancies

@o-sdn-o

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants