-
Notifications
You must be signed in to change notification settings - Fork 354
add back explicit termination of preauth child process #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latestw_all
Are you sure you want to change the base?
add back explicit termination of preauth child process #814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the grace alarm handler behavior on Windows to ensure both session processes exit when LoginGraceTime expires, and includes a minor formatting correction.
- Added Windows-specific logic to explicitly kill the child process when the login grace period expires
- Updated test expectations to verify both session processes exit after grace timeout
- Removed trailing whitespace from a comment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sshd-session.c | Added Windows-specific grace alarm handler to kill child process via pmonitor PID; removed trailing whitespace from comment |
| regress/pesterTests/SSHD.Tests.ps1 | Updated test assertion to expect both session processes to exit after LoginGraceTime expires |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
| send_config_state(int fd, struct sshbuf* conf) | ||
| { | ||
| /* copied from send_rexec_state() in sshd.c | ||
| /* copied from send_rexec_state() in sshd.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this trailing space from upstream? I would leave it unchanged if that is the case just to reduce discrepancies
PR Summary
PR Context