export stopping base base class and minor refactor#2
Open
Nvillaluenga wants to merge 2 commits intoPranjal2041:mainfrom
Open
export stopping base base class and minor refactor#2Nvillaluenga wants to merge 2 commits intoPranjal2041:mainfrom
Nvillaluenga wants to merge 2 commits intoPranjal2041:mainfrom
Conversation
Nvillaluenga
commented
Jan 30, 2024
Nvillaluenga
commented
- Export base class to allow users to create their own stopping criteria
- Minor refactor fix of conf_thresh type to float
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.