refactor: delete unused dto

PrayHelper · Dec 4, 2023 · cb7db7b · cb7db7b
1 parent 03c98c7
commit cb7db7b
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 52 deletions.
diff --git a/src/main/java/com/uspray/uspray/DTO/sharedpray/response/SharedPrayListResponseDto.java b/src/main/java/com/uspray/uspray/DTO/sharedpray/response/SharedPrayListResponseDto.java
diff --git a/src/main/java/com/uspray/uspray/controller/ShareController.java b/src/main/java/com/uspray/uspray/controller/ShareController.java
@@ -6,7 +6,6 @@
 import com.uspray.uspray.DTO.sharedpray.request.SharedPrayDeleteRequestDto;
 import com.uspray.uspray.DTO.sharedpray.request.SharedPrayRequestDto;
 import com.uspray.uspray.DTO.sharedpray.request.SharedPraySaveRequestDto;
-import com.uspray.uspray.DTO.sharedpray.response.SharedPrayListResponseDto;
 import com.uspray.uspray.DTO.sharedpray.response.SharedPrayResponseDto;
 import com.uspray.uspray.exception.SuccessStatus;
 import com.uspray.uspray.service.ShareFacade;
@@ -36,14 +35,13 @@
 @Tag(name = "Shared pray", description = "기도제목 공유 관련 API")
 public class ShareController {
 
-    private final ShareService shareService;
     private final ShareFacade shareFacade;
 
     @GetMapping
     @ApiResponse(
         responseCode = "200",
         description = "공유받은 기도제목 조회 (보관함 조회)",
-        content = @Content(schema = @Schema(implementation = SharedPrayListResponseDto.class))
+        content = @Content(schema = @Schema(implementation = SharedPrayRequestDto.class))
     )
     @Operation(summary = "공유받은 기도제목 조회 (보관함 조회)")
     public ApiResponseDto<List<SharedPrayResponseDto>> getSharedPrayList(

diff --git a/src/main/java/com/uspray/uspray/service/ShareService.java b/src/main/java/com/uspray/uspray/service/ShareService.java
@@ -1,20 +1,9 @@
 package com.uspray.uspray.service;
 
-import com.uspray.uspray.DTO.sharedpray.request.SharedPrayRequestDto;
-import com.uspray.uspray.DTO.sharedpray.response.SharedPrayResponseDto;
-import com.uspray.uspray.domain.Member;
-import com.uspray.uspray.domain.Pray;
 import com.uspray.uspray.domain.SharedPray;
-import com.uspray.uspray.exception.ErrorStatus;
-import com.uspray.uspray.exception.model.CustomException;
-import com.uspray.uspray.exception.model.NotFoundException;
-import com.uspray.uspray.infrastructure.MemberRepository;
-import com.uspray.uspray.infrastructure.PrayRepository;
 import com.uspray.uspray.infrastructure.SharedPrayRepository;
 import java.time.LocalDate;
 import java.util.List;
-import java.util.Objects;
-import java.util.stream.Collectors;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
@@ -24,27 +13,6 @@
 public class ShareService {
 
     private final SharedPrayRepository sharedPrayRepository;
-    private final MemberRepository memberRepository;
-
-    @Transactional
-    public void deleteSharedPray(String userId, Long sharedPrayId) {
-
-        Member member = memberRepository.getMemberByUserId(userId);
-        if (!sharedPrayRepository.existsById(sharedPrayId)) {
-            throw new NotFoundException(ErrorStatus.NOT_FOUND_SHARED_PRAY_EXCEPTION, ErrorStatus.NOT_FOUND_SHARED_PRAY_EXCEPTION.getMessage());
-        }
-        List<SharedPray> sharedPrayList = sharedPrayRepository.findAllByMemberOrderByCreatedAtDesc(member);
-
-        // 본인 sharedPray가 아니면 지우지 못하게 막아야 함
-        // 본인 sharedPray를 가지고 와서 아이디가 일치하면 삭제, 아니면 exception 발생
-        for (SharedPray s : sharedPrayList) {
-            if (Objects.equals(s.getId(), sharedPrayId)) {
-                sharedPrayRepository.deleteById(sharedPrayId);
-                return;
-            }
-        }
-        throw new CustomException(ErrorStatus.DELETE_NOT_AUTHORIZED_EXCEPTION, ErrorStatus.DELETE_NOT_AUTHORIZED_EXCEPTION.getMessage());
-    }
 
     @Transactional
     public void cleanSharedPray(LocalDate threshold) {