Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#32 history api #50

Merged
merged 16 commits into from
Nov 9, 2023
Merged

Feat/#32 history api #50

merged 16 commits into from
Nov 9, 2023

Conversation

Sion99
Copy link
Member

@Sion99 Sion99 commented Nov 7, 2023 •
edited
Loading

✅ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 변경
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

📌 관련 이슈

ex) closed #32

✨ 과제 내용

  • 히스토리 domain 생성
  • 히스토리 CRUD 기능 추가
  • 히스토리 검색 기능 추가 (querydsl)

📸 스크린샷(선택)

📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들

@Sion99 Sion99 added the 🚀개발 새로운 기능을 추가 했을 때 label Nov 7, 2023
@Sion99 Sion99 self-assigned this Nov 7, 2023
@Sion99 Sion99 linked an issue Nov 7, 2023 that may be closed by this pull request
[feat] 히스토리 관련 api #32
Closed
7 tasks
baebae02
baebae02 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@baebae02 baebae02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드만 봐도 고생하신 게 느껴지네요 특히 HistoryService...정말 수고 많으셨어요 !!!!

dong2ast
dong2ast approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현해야 할 기능이 많았는데 꼼꼼히 구현을 하셨군요!
고생 많으셨습니다👍

src/main/java/com/uspray/uspray/controller/HistoryController.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/controller/HistoryController.java Show resolved Hide resolved
src/main/java/com/uspray/uspray/domain/History.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/infrastructure/querydsl/history/HistoryRepositoryImpl.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/HistoryService.java Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/HistoryService.java Show resolved Hide resolved
@Sion99 Sion99 merged commit 5faf8bc into main Nov 9, 2023
1 check passed
@Sion99 Sion99 deleted the feat/#32-history-api branch November 9, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baebae02 baebae02 baebae02 approved these changes

@dong2ast dong2ast dong2ast approved these changes

Assignees

@Sion99 Sion99

Labels
🚀개발 새로운 기능을 추가 했을 때
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 히스토리 관련 api
3 participants
@Sion99 @dong2ast @baebae02