Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prayService #54

Merged
merged 18 commits into from
Nov 14, 2023
Merged

feat: add prayService #54

merged 18 commits into from
Nov 14, 2023

Conversation

baebae02
Copy link
Member

@baebae02 baebae02 commented Nov 9, 2023

✅ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 변경
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

📌 관련 이슈

#46

✨ 과제 내용

  • Pray 기도하기 (PrayService)
  • Pray Entity 수정하기 (PrayService)
  • Pray List 수정하기 (PrayService)
  • Pray 또 기도하기 (HistoryService)

📸 스크린샷(선택)

📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들

@baebae02 baebae02 self-assigned this Nov 9, 2023
Copy link
Member

@Sion99 Sion99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 완성해주셨네요! 드디어 기도하기 API가 생겼네요 ㅎㅎ
고생 많으셨습니다~

@baebae02
Copy link
Member Author

한 PR 안에 너무 많은 내용이 담길 듯 하여 #46 issue PR 2개로 쪼개서 작업하겠습니다 ~

@baebae02
Copy link
Member Author

한 PR 안에 너무 많은 내용이 담길 듯 하여 #46 issue PR 2개로 쪼개서 작업하겠습니다 ~

브랜치 쪼갰더니 file changed가 그대로 따라가네요 ... 그냥 여기까지 PR 받고 이어서 하겠습니다

Copy link
Contributor

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업할 양이 많았을텐데 고생 많으셨습니다 :)

@baebae02 baebae02 merged commit 230923b into main Nov 14, 2023
1 check passed
@baebae02 baebae02 deleted the feat/prayServiceDetail branch November 14, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants