Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#58 group service #61

Merged
merged 22 commits into from
Nov 24, 2023
Merged

Feat/#58 group service #61

merged 22 commits into from
Nov 24, 2023

Conversation

Sion99
Copy link
Member

@Sion99 Sion99 commented Nov 17, 2023 •
edited
Loading

✅ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 변경
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

📌 관련 이슈

ex) closed #58

✨ 과제 내용

  • 모임 엔티티 생성
  • 모임 생성, 삭제, 모임 이름 수정, 모임 리스트 조회 기능
  • 모임 일반 회원 추가, 탈퇴 기능
  • 모임 관리자 회원 권환 조정 (위임 및 모임 삭제 기능)

📸 스크린샷(선택)

📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들

@Sion99 Sion99 added the 🚀개발 새로운 기능을 추가 했을 때 label Nov 17, 2023
@Sion99 Sion99 self-assigned this Nov 17, 2023
@Sion99 Sion99 linked an issue Nov 17, 2023 that may be closed by this pull request
Group Service 생성 #58
Closed
1 task
dong2ast
dong2ast reviewed Nov 18, 2023
View reviewed changes
Copy link
Contributor

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 되게 많은 기능이었는데 꼼꼼하게 구현 잘 하셨네요!
고생하셨습니다~~

src/main/java/com/uspray/uspray/DTO/group/response/GroupDetailResponseDto.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/DTO/group/request/GroupMemberRequestDto.java Show resolved Hide resolved
src/main/java/com/uspray/uspray/domain/Group.java Show resolved Hide resolved
src/main/java/com/uspray/uspray/infrastructure/querydsl/group/GroupRepositoryImpl.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/infrastructure/querydsl/group/GroupRepositoryImpl.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/GroupService.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/GroupService.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/GroupService.java Outdated Show resolved Hide resolved
baebae02
baebae02 approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@baebae02 baebae02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

많이 복잡한 모임기도인데 수고하셨어요 ㅠ ㅠ

src/main/java/com/uspray/uspray/controller/GroupController.java Show resolved Hide resolved
src/main/java/com/uspray/uspray/controller/GroupController.java Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/GroupService.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/GroupService.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/GroupService.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/GroupService.java Outdated Show resolved Hide resolved
@Sion99 Sion99 merged commit 470838f into main Nov 24, 2023
1 check passed
@Sion99 Sion99 deleted the feat/#58-group-service branch November 24, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dong2ast dong2ast dong2ast approved these changes

@baebae02 baebae02 baebae02 approved these changes

Assignees

@Sion99 Sion99

Labels
🚀개발 새로운 기능을 추가 했을 때
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group Service 생성
3 participants
@Sion99 @dong2ast @baebae02