Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cancel pray and make notification log #69

Merged
merged 45 commits into from
Dec 2, 2023
Merged

feat: cancel pray and make notification log #69

merged 45 commits into from
Dec 2, 2023

Conversation

baebae02
Copy link
Member

✅ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 변경
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

📌 관련 이슈

#67

✨ 과제 내용

📸 스크린샷(선택)

📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들

@baebae02 baebae02 linked an issue Nov 24, 2023 that may be closed by this pull request
기도제목 취소하기, 알림함 (PrayService, Notification) #67
Closed
2 tasks
@baebae02 baebae02 changed the title refactor: edit pray update category logic feat: cancel pray and make notification log Nov 24, 2023
baebae02 and others added 24 commits November 24, 2023 20:08
@baebae02
fix: rebase main
77cf684
@Sion99 @baebae02
feat: TokenNotValid 예외처리 추가
def5dfd
@baebae02
feat: edit category order api
25c9cde
@baebae02
feat: get category list api
9dae43f
@baebae02
feat: change category order when create
249a752
@baebae02
refactor: edit map in get category list
150d872
@baebae02
refactor: combine repository method
b1b3590
@baebae02
refactor: edit update order logic
ac6af04
@Sion99 @baebae02
chore: rename workflows
ecba50c
@Sion99 @baebae02
feat: add group entity
2dda2b5
@Sion99 @baebae02
feat: add Group list service
8b228ce
@Sion99 @baebae02
refactor: add group description and change Dto
0536f07
@Sion99 @baebae02
feat: add group create service
2f7ac03
@Sion99 @baebae02
feat: add group create service
06eba41
@Sion99 @baebae02
refactor: change GroupResponseDto
8b9f99f
@Sion99 @baebae02
chore: remove unnecessary code
e7e3a8b
@Sion99 @baebae02
feat: add validation to GroupResponseDto
93522ad
@Sion99 @baebae02
feat: add changeGroupName, changeGroupLeader, kickGroupMember, delete…
e0c22e4 
…Group
@Sion99 @baebae02
feat: add validation to GroupRequestDto
c067d56
@Sion99 @baebae02
chore: fix tab indent
0e5648e
@Sion99 @baebae02
feat: add addGroupMember, leaveGroup
0c1464d
@Sion99 @baebae02
feat: add Group to initDb
8bd882f
@Sion99 @baebae02
fix: fix certain logic that prevents group leaders from leaving a group
44e7304
@Sion99 @baebae02
fix: build connection between member and group
8fa1243
@baebae02 baebae02 self-assigned this Nov 28, 2023
@baebae02
Copy link
Member Author

코드 매트릭 최대한 초록불 유지하도록 노력했습니다
복합키 사용해서 알림함 로그만들었고, 기도제목 취소하기 API 만들었습니다.
변경사항이 조금 많네요 🥲 ...
@Sion99 @dong2ast

dong2ast
dong2ast reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

늘 새로운 도전을 시도하는게 멋집니다~~
고생하셨어요!

src/main/java/com/uspray/uspray/domain/NotificationLog.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/domain/NotificationLog.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/PrayService.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/PrayService.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/PrayService.java Outdated Show resolved Hide resolved
Sion99
Sion99 approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@Sion99 Sion99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드를 작성하시면서 고민을 많이 하신 것이 느껴집니다. 고생 많으셨습니다!

@baebae02 baebae02 merged commit 26bb4e3 into main Dec 2, 2023
1 check passed
@baebae02 baebae02 deleted the feat/67-cancel-pray branch December 2, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dong2ast dong2ast dong2ast approved these changes

@Sion99 Sion99 Sion99 approved these changes

Assignees

@baebae02 baebae02

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

기도제목 취소하기, 알림함 (PrayService, Notification)
3 participants
@baebae02 @dong2ast @Sion99