Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Group API #71

Merged
merged 14 commits into from
Dec 2, 2023
Merged

Refactor: Group API #71

merged 14 commits into from
Dec 2, 2023

Conversation

Sion99
Copy link
Member

@Sion99 Sion99 commented Nov 28, 2023 •
edited
Loading

✅ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 변경
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

📌 관련 이슈

closed #68

✨ 과제 내용

  • Group과 Member를 다대다 양방향 매핑에서 GroupMember 중간 엔티티 생성하여 해소하였습니다.
  • 이에 따른 GroupService 로직을 일부 수정하였습니다.
  • Group에 속해 있는 Member를 조회하는 서비스를 추가하였습니다.

📸 스크린샷(선택)

📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들

@Sion99 Sion99 added 🚀개발 새로운 기능을 추가 했을 때 ✅해결 각종 오류 및 문제를 해결했을 때 labels Nov 28, 2023
@Sion99 Sion99 self-assigned this Nov 28, 2023
@Sion99 Sion99 linked an issue Nov 28, 2023 that may be closed by this pull request
[refactor] 모임 API #68
Closed
3 tasks
baebae02
baebae02 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@baebae02 baebae02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !!

src/main/java/com/uspray/uspray/service/GroupFacade.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/GroupFacade.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/infrastructure/querydsl/group/GroupRepositoryImpl.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/infrastructure/querydsl/group/GroupRepositoryImpl.java Outdated Show resolved Hide resolved
baebae02
baebae02 approved these changes Dec 2, 2023
View reviewed changes
Copy link
Member

@baebae02 baebae02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정이 엄청 많으신데 수고하셨습니다
마스킹 유틸은 앞으로도 잘 쓸 것 같아 좋네요 ㅎ.ㅎ

src/main/java/com/uspray/uspray/DTO/group/response/GroupMemberResponseDto.java Show resolved Hide resolved
src/main/java/com/uspray/uspray/InitDb.java Outdated Show resolved Hide resolved
dong2ast
dong2ast approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!!!~!

@Sion99 Sion99 merged commit 578e3de into main Dec 2, 2023
1 check passed
@Sion99 Sion99 deleted the 68-refactor-group-api branch December 2, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dong2ast dong2ast dong2ast approved these changes

@baebae02 baebae02 baebae02 approved these changes

Assignees

@Sion99 Sion99

Labels
✅해결 각종 오류 및 문제를 해결했을 때 🚀개발 새로운 기능을 추가 했을 때
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] 모임 API
3 participants
@Sion99 @dong2ast @baebae02