-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/#70 grouppray additional function #81
Conversation
# Conflicts: # src/main/java/com/uspray/uspray/exception/SuccessStatus.java
+ 반환 타입 날짜별로 묶은 Map으로 변경 + 모임 기도제목 생성시 글쓴이 저장
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무 복잡하고 피그마를 봐도 이해가 잘 되지 않는 Group을 열심히 만들어주셔서 너무 너무 감사합니다 ..아직 코드 다 못봐서 PR 추가할 예정입니다!
src/main/java/com/uspray/uspray/infrastructure/querydsl/grouppray/GroupPrayRepositoryImpl.java
Show resolved
Hide resolved
src/main/java/com/uspray/uspray/infrastructure/querydsl/grouppray/GroupPrayRepositoryImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
내가 만든 기도제목 A를 불러오기해서 그룹에 가져왔을 때
A를 완료하거나 삭제하면 그룹안에서도 같이 완료되고 삭제되어야한대요 !
이건 제가 이 PR 머지되고 나서 따로 PR 파서 하겠습니다 :)
src/main/java/com/uspray/uspray/controller/GroupPrayController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굉장히 까다로운 Group Pray인데 깔끔하고 가독성 높은 코드로 잘 짜주신 것 같습니다! 👍
✅ PR 타입(하나 이상의 PR 타입을 선택해주세요)
📌 관련 이슈
ex) closed #Issue_number
closed #70
✨ 과제 내용
📸 스크린샷(선택)
📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들