Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Shared Pray #83

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Refactor: Shared Pray #83

merged 4 commits into from
Dec 21, 2023

Conversation

Sion99
Copy link
Member

@Sion99 Sion99 commented Dec 4, 2023 •
edited
Loading

✅ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 기능 변경
  • 기능 삭제
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

📌 관련 이슈

ex) closed #42

✨ 과제 내용

Shared Pray 서비스를 수정하였습니다.

  • 공유 url과 jwt 토큰을 통해 기도제목을 받도록 수정하였습니다.
  • 보관함의 목록을 한 번에 여러개 선택하여 동작을 수행하도록 수정하였습니다.
  • PrayType.SHARED 반영하였습니다.

📸 스크린샷(선택)

📚 레퍼런스 (또는 새로 알게 된 내용) 혹은 궁금한 사항들

@Sion99 Sion99 added the 🤖수정 기능의 수정 사항이 있을 때 label Dec 4, 2023
@Sion99 Sion99 self-assigned this Dec 4, 2023
@Sion99 Sion99 linked an issue Dec 4, 2023 that may be closed by this pull request
[refactor] 기도제목 공유 api #42
Closed
4 tasks
dong2ast
dong2ast approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~

src/main/java/com/uspray/uspray/service/ShareFacade.java Outdated Show resolved Hide resolved
src/main/java/com/uspray/uspray/service/ShareFacade.java Outdated Show resolved Hide resolved
dong2ast
dong2ast reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@dong2ast dong2ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 conflict 났던데 한번 봐주세요~!

baebae02
baebae02 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@baebae02 baebae02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요 !!

@baebae02 baebae02 merged commit b23d990 into main Dec 21, 2023
1 check passed
@baebae02 baebae02 deleted the 42-refactor-shared-pray branch December 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dong2ast dong2ast dong2ast approved these changes

@baebae02 baebae02 baebae02 approved these changes

Assignees

@Sion99 Sion99

Labels
🤖수정 기능의 수정 사항이 있을 때
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor] 기도제목 공유 api
3 participants
@Sion99 @dong2ast @baebae02